-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8485] - Unit Tests for Object Storage Gen2 feature #10862
Merged
harsh-akamai
merged 8 commits into
linode:develop
from
harsh-akamai:feature/M3-8485-browsing-buckets-and-objects-unit-and-itegration-tests
Sep 12, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
35c2bab
upcoming:[M3-8485] - Browsing Buckets & Objects - Unit Tests
harsh-akamai 57411a5
test: Unit test for 'Endpoint Type' column in the Bucket Landing Table
harsh-akamai f604929
Merge branch 'develop' into feature/M3-8485-browsing-buckets-and-objeβ¦
harsh-akamai 25d4b26
test: [M3-8485] - updated tests for object storage bucket feature
harsh-akamai eef2af5
Merge branch 'develop' into feature/M3-8485-browsing-buckets-and-objeβ¦
harsh-akamai 9c1d0e8
Merge branch 'develop' into feature/M3-8485-browsing-buckets-and-objeβ¦
harsh-akamai da4b474
test: [M3-8485] fixed failing unit test
harsh-akamai 8974ea4
test: [M3-8485] - udpated tests that need to wait for OBJGen2 flag
harsh-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
renderWithThemeAndHookFormContext
is unnecessary since the component doesn't need a Hook Form Context. UserenderWithTheme
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the component doesn't need a Hook Form, but M3-8501(optimzing AccessSelect.tsx using Hook Form) is in progress. Hence, I decided to go with
renderWithThemeAndHookFormContext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh understood. Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, each PR should be self-contained and generally should not include changes for another ticket. This prevents issues when, for example, the other ticket is closed or modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted ποΈ