-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8513] - Update Node.js from 18.14
to 20.17
#10866
refactor: [M3-8513] - Update Node.js from 18.14
to 20.17
#10866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing AxiosError: Request failed with status code 502
in CI tests
@AzureLatte those are unrelated - it's sad state of affairs @jdamore-linode described to me as such (sharig cause it'll keep happening and will get a bit better at the restart of the month):
|
@abailly-akamai I never realized this issue was cyclical on a monthly basis; this was a really helpful read. Thanks to you and Joe for sharing. ππΌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Confirmed:
- my node version updates to
20.17
- local development works as expected (both yarn up / yarn dev)
- production builds work via the preview link
- Storybook builds and runs locally
- Cypress runs locally
- the rest of CI passes (save the e2e tests that are still running and we know will at least partially fail because of the
502
s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should help indeed, thx for the update π
Everything seems to behave well on my end with this update
Approving pending resolving test failures
Description π
20.17
) β¬οΈWhy? β
Screen.Recording.2024-08-30.at.12.07.43.PM.mov
How to test π§ͺ
Note
When testing this, make sure your local environment uses Node
20.17
. Check that with (node --version
)If you use Volta or NVM to manage your node version, it should update automatically for you, but double check this.
yarn up
/yarn dev
)Code Coverage / base_branch
can safely be disregardedAs an Author I have considered π€