Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8502] - Allow regions to be searched by ID when Gecko is enabled #10871

Conversation

jdamore-linode
Copy link
Contributor

@jdamore-linode jdamore-linode commented Sep 3, 2024

Description 📝

This fixes an issue where users cannot search for a region by its ID using a RegionSelect when Gecko is enabled due to the layout changes made to our region options.

This fixes the issue by passing a custom filter to the Autocomplete when Gecko is enabled. There should be no impact when Gecko is not enabled.

Changes 🔄

  • Allow regions to be searched by ID when Gecko is enabled

Target release date 🗓️

N/A

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2024-09-03 at 10 16 35 AM Screenshot 2024-09-03 at 10 15 53 AM

How to test 🧪

Reproduction steps

In develop:

  • yarn dev
  • Enable MSW with Core + Distributed region preset and Gecko feature flag to enable Gecko
  • Go to Linode create page or another page with a region select
  • Search for a region by its ID (ex: id-cgk)
  • Observe that region is not found

Verification steps

In this branch:

  • yarn dev
  • Enable MSW with Core + Distributed region preset and Gecko feature flag to enable Gecko
  • Go to Linode create page or another page with a region select
  • Search for a region by its ID (ex: id-cgk)
  • Confirm that region is found
  • Confirm that region select continues working as expected when Gecko is not enabled

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode requested a review from a team as a code owner September 3, 2024 14:17
@jdamore-linode jdamore-linode requested review from bnussman-akamai and hana-akamai and removed request for a team September 3, 2024 14:17
Copy link

github-actions bot commented Sep 3, 2024

Coverage Report:
Base Coverage: 86.15%
Current Coverage: 86.15%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@jdamore-linode jdamore-linode added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Sep 4, 2024
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 4, 2024
@jdamore-linode jdamore-linode merged commit c02a7df into linode:develop Sep 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants