-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8006] - DBaaS 2.0 Create #10872
feat: [UIE-8006] - DBaaS 2.0 Create #10872
Conversation
@corya-akamai thx for the contribution! How does one get the "Managed Databases V2" capability? |
Coverage Report: β
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as described.
create-database
e2e failing is suspicious approving confirming this test.
Let a couple other comments for consideration
packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @corya-akamai - Alban is right that the Cypress failure for create-database.spec.ts
does seem related here. That test fails locally for me consistently for all 3 test cases at the point where it's trying to await the mocked createDatabase request. I don't know what the issue is here right off - I confirmed can still create a database in the UI by clicking the button. And although we're not checking for 2 Nodes as a option, 1 Node and 3 Nodes are still present and selectable in the test. (Maybe @AzureLatte or @jdamore-linode can spot what I'm overlooking.)
Other than that, this PR looked good - I had some minor comments on test clean up, thank you for the coverage.
The error was due to shared mock data https://github.com/linode/manager/pull/10872/files#r1744096806. The create-database.spec is now passing. I noticed the resize-database.spec is failing, but that seems to be failing back to v1.21.0 when it was added https://github.com/linode/manager/pull/10461/files. Maybe @sujai-git or stayal can fix. I tried
but that didn't seem to resolve the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corya-akamai Good find and fix on the Capability - that makes sense.
I went back and looked at the CI e2e run and noticed it's resize-linode.spec.ts
, not to be confused with resize-database.spec.ts
, that is failing (as well as longview.spec.ts
). I wouldn't expect the changes in this PR to have any impact on those tests, nor have I seen them fail consistently in CI recently, so I think those failures were just flukes.
Just for confirmation's sake, all of the following passed for me locally. Unit tests are fine as well; the code coverage action was just skipped.
(I'm going to go ahead and merge this now.)
Description π
DBaaS 2.0 enhancements to create page
Changes π
Target release date ποΈ
9/10/24
How to test π§ͺ
Prerequisites
Verification steps
As an Author I have considered π€
Check all that apply