Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [OCA-1418] - Adds September 2024 Marketplace apps #10874

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: [OCA-1418] - Adds September 2024 Marketplace apps #10874

merged 4 commits into from
Sep 4, 2024

Conversation

josephcardillo-akamai
Copy link
Contributor

Description 📝

Adds new Marketplace apps for September 2024
Apache Spark Cluster

Changes 🔄

List any change relevant to the reviewer.

  • updates oneClickAppsv2.ts
  • adds SVG public assets

Target release date 🗓️

September 16, 2024

Preview 📷

apache_spark_screenshot1
apache_spark_screenshot2

@josephcardillo-akamai josephcardillo-akamai requested a review from a team as a code owner September 3, 2024 16:15
@josephcardillo-akamai josephcardillo-akamai requested review from dwiley-akamai and hkhalil-akamai and removed request for a team September 3, 2024 16:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.2%
Current Coverage: 86.2%

mjac0bs
mjac0bs approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephcardillo! Confirmed that Apache Spark is showing up with the correct icons, a cluster chip, no typos, link addresses that redirect correctly (or will on 9/16). Approving pending minor updates to the changeset.

Screenshot 2024-09-03 at 9 59 05 AM

packages/manager/.changeset/pr-10874-added-1725380346411.md Outdated Show resolved Hide resolved
dwiley-akamai
dwiley-akamai approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache Spark Cluster appears in the "New Apps" section when pointing at prod and the app drawer looks good ✅

packages/manager/.changeset/pr-10874-added-1725380346411.md Outdated Show resolved Hide resolved
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Sep 3, 2024
@mjac0bs mjac0bs merged commit 123548e into linode:develop Sep 4, 2024
19 checks passed
This was referenced Sep 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@hkhalil-akamai hkhalil-akamai Awaiting requested review from hkhalil-akamai hkhalil-akamai is a code owner automatically assigned from linode/frontend

Assignees

@josephcardillo-akamai josephcardillo-akamai

Labels
Approved Multiple approvals and ready to merge! Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephcardillo-akamai @dwiley-akamai @mjac0bs