Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8435] - Cypress integration test for Object Storage Gen2: E3 Endpoint #10880

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Sep 4, 2024

Changes πŸ”„

  • New Integration Test for Object Storage Gen2: E3 Endpoint - Bucket Creation

Target release date πŸ—“οΈ

N/A

How to test πŸ§ͺ

  • yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts"

Requirements:

  • Visiting /object-storage/buckets/create causes "Create Bucket" drawer to open
  • Users can select "E3" endpoint type for regions that support E3 endpoint types
    • This will require mocking the response to the API endpoint types request to ensure that "E3" is available for the selected region
  • Upon selecting "E3" endpoint type, rate limit table appears
    • Rate limit table contains expected data
      • (This data is currently pending, but notably it should differ from E2's rate limiting info)
  • Informational notice text is displayed alongside rate limit table:
    • Specifies the maximum Requests Per Second (RPS) for a bucket. To increase it to High, open a support ticket. Understand bucket rate limits.
  • Upon clicking "Create Bucket" with "E3" endpoint type selected, Cloud fires an API bucket create request with the following data in its payload:
    • cors_enabled is false
    • endpoint_type is 'E3'
    • s3_endpoint is present if corresponding endpoint mock contains non-null s3_endpoint
      • At least one of these subtasks should test the case when s3_endpoint is specified, and at least one of these subtasks should test the case when s3_endpoint is omitted
  • Upon creating bucket, the "Create Bucket" drawer closes and new bucket appears in the landing page
    • The correct information is displayed alongside the new bucket:
      • Label
      • Region
      • Endpoint type
      • Endpoint URL

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@jaalah-akamai jaalah-akamai added e2e Indicates that a PR touches Cypress tests in some way Object Storage Gen2 labels Sep 4, 2024
@jaalah-akamai jaalah-akamai self-assigned this Sep 4, 2024
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner September 4, 2024 01:28
@jaalah-akamai jaalah-akamai requested review from AzureLatte and removed request for a team September 4, 2024 01:28
Copy link

github-actions bot commented Sep 4, 2024

Coverage Report: βœ…
Base Coverage: 86.4%
Current Coverage: 86.4%

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky issue in CI tests.
The newly added test passed locally though.
Thank you!

@jaalah-akamai jaalah-akamai requested review from a team, dwiley-akamai and carrillo-erik and removed request for a team September 6, 2024 17:12
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… confirmed this test passes locally too πŸŽ‰

@coliu-akamai coliu-akamai added Missing Changeset Approved Multiple approvals and ready to merge! labels Sep 6, 2024
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner September 6, 2024 18:20
@jaalah-akamai jaalah-akamai requested review from hkhalil-akamai and abailly-akamai and removed request for a team September 6, 2024 18:20
@jaalah-akamai
Copy link
Contributor Author

Thanks I'll make the changes in this PR πŸ™

@jaalah-akamai
Copy link
Contributor Author

I'm not sure how the // Confirm that bucket is created, initiate deletion for cleanup is passing in the CI because locally it always fails, but this was code that was pre-existing since E0

@jaalah-akamai jaalah-akamai merged commit 516ae68 into linode:develop Sep 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way Object Storage Gen2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants