-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-6615, M3-8507] - Cypress test for empty Linode landing page and restricted user Linode landing page #10882
test: [M3-6615, M3-8507] - Cypress test for empty Linode landing page and restricted user Linode landing page #10882
Conversation
… and restricted user Linode landing page
…icted user Linode landing page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @subsingh-akamai, nice work! Made a couple small suggestions and offered some advice but overall this is already really solid 👍
packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changeset!
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks @subsingh-akamai!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed tests pass
Nice work and comments throughout the tests were super helpful! 🎉
(also - just edited your PR comment so that the internal tickets aren't direct links - it shouldn't really matter since they're protected but just in case I guess?)
Description 📝
Added cypress test for empty Linode landing page and restricted user Linode landing page
Changes 🔄
Added below cypress tests under in spec file - cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
PRs
How to test 🧪
yarn cy:run -s cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
Verification steps
When test executed using this command
yarn cy:run -s cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
all tests should pass successfully and you should see new test added as per below screenshotAs an Author I have considered 🤔
Check all that apply