Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8518] - Add unit tests for SelectableTableRow component #10890

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Sep 5, 2024

Description πŸ“

Unit test cases for SelectableTableRow Component.

Changes πŸ”„

  • Add unit test cases for SelectableTableRow Component.

Target release date πŸ—“οΈ

9/16

How to test πŸ§ͺ

Verification steps

  • Run yarn test src/components/SelectableTableRow
  • Verify that all the test cases pass.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@pmakode-akamai pmakode-akamai added the Unit tests Improves unit test coverage label Sep 5, 2024
@pmakode-akamai pmakode-akamai self-assigned this Sep 5, 2024
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner September 5, 2024 08:18
@pmakode-akamai pmakode-akamai requested review from bnussman-akamai and carrillo-erik and removed request for a team September 5, 2024 08:18
@pmakode-akamai pmakode-akamai marked this pull request as draft September 5, 2024 08:26
@pmakode-akamai pmakode-akamai marked this pull request as ready for review September 5, 2024 08:35
Copy link

github-actions bot commented Sep 5, 2024

Coverage Report: βœ…
Base Coverage: 86.26%
Current Coverage: 86.4%

Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Clean test 🧼πŸ§ͺ

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Sep 5, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-8518-unit-tests-for-selectabletablerow-component branch from 50aa7fd to 20c3ae1 Compare September 6, 2024 05:56
@pmakode-akamai pmakode-akamai merged commit 3e1414f into linode:develop Sep 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Unit tests Improves unit test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants