Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8321] - Clean up feature flag mocks #10892

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Sep 5, 2024

Description 📝

mockGetFeatureFlagClientstream and makeFeatureFlagData are no longer required to mock feature flags.

Changes 🔄

  • Clean up mockGetFeatureFlagClientstream and makeFeatureFlagData.
  • Remove any imports that become unneeded as a result of this cleanup.

How to test 🧪

CI tests all pass. Or running tests locally using:

yarn cy:run

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Sep 5, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner September 5, 2024 14:32
@AzureLatte AzureLatte requested review from jdamore-linode and removed request for a team September 5, 2024 14:32
@AzureLatte AzureLatte requested a review from a team as a code owner September 5, 2024 14:34
@AzureLatte AzureLatte requested review from jaalah-akamai and coliu-akamai and removed request for a team September 5, 2024 14:34
Copy link

github-actions bot commented Sep 5, 2024

Coverage Report:
Base Coverage: 86.4%
Current Coverage: 86.4%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so nice! 🧼

Thanks @AzureLatte!

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧼

Thank you!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 5, 2024
@AzureLatte AzureLatte merged commit f83b918 into linode:develop Sep 10, 2024
19 checks passed
@AzureLatte AzureLatte deleted the M3-8321 branch September 10, 2024 15:41
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
* Remove feature flag mocks

* Added changeset: Clean up feature flag mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants