-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8321] - Clean up feature flag mocks #10892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureLatte
requested review from
jdamore-linode
and removed request for
a team
September 5, 2024 14:32
AzureLatte
requested review from
jaalah-akamai and
coliu-akamai
and removed request for
a team
September 5, 2024 14:34
Coverage Report: ✅ |
jdamore-linode
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so nice! 🧼
Thanks @AzureLatte!
coliu-akamai
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 🧼
Thank you!
coliu-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Ready for Review
labels
Sep 5, 2024
12 tasks
This was referenced Sep 13, 2024
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Sep 23, 2024
* Remove feature flag mocks * Added changeset: Clean up feature flag mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
mockGetFeatureFlagClientstream and makeFeatureFlagData are no longer required to mock feature flags.
Changes 🔄
How to test 🧪
CI tests all pass. Or running tests locally using:
As an Author I have considered 🤔
Check all that apply