-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8530] - Allow quoted strings in Search v2 and improve StackScript searching on Linode Create v2 #10894
change: [M3-8530] - Allow quoted strings in Search v2 and improve StackScript searching on Linode Create v2 #10894
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use spaces by using a quoted string ✅
Can use and
in the search ✅
How are users informed of the rules governing the search functionality?
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
That's a good question @dwiley-akamai. For now, I don't think we'll add new information users about the new search syntax, but as part of Search v2 we will make sure we address that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed both cases now work as expected.
FWIW, it would be nice for the tooltip to show an actual example because it's confusing with the quotes in there.
we could change:
Hint: try searching for a specific item by prepending your search term with "username:", "label:", or "description:"
to
Hint: try searching for a specific item by prepending your search term with `username:`, `label:`, or `description:`. example: `label: "my label"`
Good call @abailly-akamai I'll update the tooltip to include that example |
Thoughts? @abailly-akamai @dwiley-akamai This might be a bit much. We can always go with the more simple copy that @abailly-akamai suggested |
@bnussman-akamai i think that's great! it's a bit intense but it's very clear 👍 |
That looks good to me as well 🚀 |
Description 📝
Allow spaces in search
My StackScript
, with this PR, you can search using a quoted string:label: "My StackScript"
label: My StackScript
instead oflabel: "My StackScript"
, but I couldn't quite get that working. I think it would require a significant rework of our search parser. I think a quoted string is probably a good step forward for now, but let me know if you disagree!Fix searching with
and
on StackScript tab of Linode CreatePreview 📷
and
queriesHow to test 🧪
and
in your searchAs an Author I have considered 🤔