Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8531] - Hide Beta price notice for Gecko LA #10896

Merged

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Sep 5, 2024

Description 📝

Gecko LA will be billed so we want to hide the temp Beta pricing notice if LA is enabled

Changes 🔄

List any change relevant to the reviewer.

  • Hide Beta pricing notice in the Linode Plan table when a distributed region is selected for Gecko LA
  • Rename GA references to LA

Preview 📷

Before After
image gecko la plan table

How to test 🧪

Prerequisites

(How to setup test environment)

  • Ensure your account has the new-dc-testing, new-dc-testing-gecko, edge_testing and edge_compute customer tags
  • Pull this PR and run it locally pointing to dev API

Verification steps

(How to verify changes)

  • Select an image compatible with distributed regions (e.g. Ubuntu 24.04 LTS)
  • Select a distributed region
  • The Linode Plan table should not display the Beta pricing notice

Ensure Gecko Beta still shows the pricing notice.

  • To test Gecko Beta locally, you can add the following to useFlags.ts (We do not want to change the LD flag globally since other teams rely on it):
  • ...mockFlags,
    gecko2: {
    enabled: true,
    la: false
    }

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Gecko LA Relating to Gecko LA label Sep 5, 2024
@hana-akamai hana-akamai self-assigned this Sep 5, 2024
@hana-akamai hana-akamai marked this pull request as ready for review September 5, 2024 17:46
@hana-akamai hana-akamai requested a review from a team as a code owner September 5, 2024 17:46
@hana-akamai hana-akamai requested review from jaalah-akamai and coliu-akamai and removed request for a team September 5, 2024 17:46
@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 5, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed pricing notice NOT shown for LA distributed region
✅ confirmed pricing notice shown for beta

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 5, 2024
@hana-akamai hana-akamai merged commit ce4bb3b into linode:develop Sep 6, 2024
19 checks passed
@hana-akamai hana-akamai deleted the M3-8531-gecko-hide-beta-price-notice branch September 6, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Gecko LA Relating to Gecko LA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants