Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [M3-8326], [M3-8055] - Create Linode - Create Using Command Line A/B Test #10906

Merged
merged 42 commits into from
Sep 13, 2024
Merged

feat: [M3-8326], [M3-8055] - Create Linode - Create Using Command Line A/B Test #10906

merged 42 commits into from
Sep 13, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Sep 9, 2024 •
edited
Loading

Description 📝

This PR uses the new feature flag for A/B testing for the Command line tools.

Changes 🔄

List any change relevant to the reviewer.

  • Created and used feature flag for A/B testing.
  • Added event emitter to track the metrics for the trackable elements in the DX tool Modal.
  • Created Metrics in the launch darkly and mapped to A/B testing experiment.

Target release date 🗓️

9/16

How to test 🧪

  • Checkout the branch and run the app
  • Navigate to Create command line tools or View code snippets Modal and click on tabs, copy icon and resources.
  • Verify experiments results in LD reflects the clicks. Reach out me for further help.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa
unit test coverage for HostNameTableCell
b274baf
@cpathipa
Revert "unit test coverage for HostNameTableCell"
f958dab 
This reverts commit b274baf.
@cpathipa
Merge branch 'linode:develop' into develop
5d0a476
@cpathipa
Merge branch 'linode:develop' into develop
93aab07
@cpathipa
Merge branch 'linode:develop' into develop
d7deb4f
@cpathipa
Merge branch 'linode:develop' into develop
a550f05
@cpathipa
Merge branch 'linode:develop' into develop
de0f63e
@cpathipa
Merge branch 'linode:develop' into develop
426c42c
@cpathipa
Merge branch 'linode:develop' into develop
3fb49a6
@cpathipa
Merge branch 'linode:develop' into develop
6c76508
@cpathipa
Merge branch 'linode:develop' into develop
1653a6b
@cpathipa
Merge branch 'linode:develop' into develop
00421cf
@cpathipa
Merge branch 'linode:develop' into develop
959730a
@cpathipa
Merge branch 'linode:develop' into develop
d9bd490
@cpathipa
Merge branch 'linode:develop' into develop
960415e
@cpathipa
Merge branch 'linode:develop' into develop
b9f4745
@cpathipa
Merge branch 'linode:develop' into develop
b0b9264
@cpathipa
Merge branch 'linode:develop' into develop
6c70559
@cpathipa
Merge branch 'linode:develop' into develop
96eb34d
@cpathipa
Merge branch 'linode:develop' into develop
74b1635
@cpathipa
Merge branch 'linode:develop' into develop
70d1422
@cpathipa
Merge branch 'linode:develop' into develop
342fd96
@cpathipa
Create feature flag for DX tools A/B testing
8744912
@cpathipa cpathipa self-assigned this Sep 9, 2024
@cpathipa cpathipa requested a review from a team as a code owner September 9, 2024 15:52
@cpathipa cpathipa requested review from dwiley-akamai and hkhalil-akamai and removed request for a team September 9, 2024 15:52
@cpathipa cpathipa marked this pull request as draft September 9, 2024 15:52
@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Sep 13, 2024
@jdamore-linode
Copy link
Contributor

@cpathipa mind pulling in the latest from develop to get the tests passing?

@cpathipa
Copy link
Contributor Author

@jdamore-linode done!

@jdamore-linode
Copy link
Contributor

Thanks @cpathipa 🙌

@cpathipa
Copy link
Contributor Author

Metrics not firing for me:

  • ❌ All Resource Links

Metrics working:

  • ✅ Initial opening of modal
  • ✅ Linode CLI Tab Selection
  • ✅ Linode CLI Copy Code Snippet Icon
  • ✅ cURL Tab Selection
  • ✅ cURL Copy Code Snippet Icon
  • ✅ Integrations Tab Selection
  • ✅ Integrations - Ansible - Copy Code Snippet Icon
  • ✅ Integrations - Terraform - Copy Code Snippet Icon
  • ✅ SDKs Tab Selection
  • ✅ SDKs - Python - Copy Code Snippet Icon
  • ✅ SDKs - Go - Copy Code Snippet Icon

I will create a bug ticket to investigate why event emitters are not firing consistently for resources.

@cpathipa
Copy link
Contributor Author

Metrics not firing for me:

  • ❌ All Resource Links

Metrics working:

  • ✅ Initial opening of modal
  • ✅ Linode CLI Tab Selection
  • ✅ Linode CLI Copy Code Snippet Icon
  • ✅ cURL Tab Selection
  • ✅ cURL Copy Code Snippet Icon
  • ✅ Integrations Tab Selection
  • ✅ Integrations - Ansible - Copy Code Snippet Icon
  • ✅ Integrations - Terraform - Copy Code Snippet Icon
  • ✅ SDKs Tab Selection
  • ✅ SDKs - Python - Copy Code Snippet Icon
  • ✅ SDKs - Go - Copy Code Snippet Icon

I will create a bug ticket to investigate why event emitters are not firing consistently for resources.

Looks like events are firing for the resources links
image

@cpathipa cpathipa changed the base branch from develop to release-v1.128.0 September 13, 2024 15:28
@cpathipa cpathipa requested a review from a team as a code owner September 13, 2024 15:28
@cpathipa cpathipa requested review from cliu-akamai and removed request for a team September 13, 2024 15:28
@cpathipa cpathipa changed the base branch from release-v1.128.0 to develop September 13, 2024 15:37
@cpathipa
Revert "Merge branch 'linode:develop' into develop"
9e54b55 
This reverts commit bfed239, reversing
changes made to 342fd96.
@cpathipa cpathipa changed the base branch from develop to release-v1.128.0 September 13, 2024 15:41
@cpathipa cpathipa changed the base branch from release-v1.128.0 to develop September 13, 2024 15:42
hkhalil-akamai
hkhalil-akamai approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified DX tools modal continues to work as expected and displays the button text based on the AB test value.

Verified LD events are being sent.

@cpathipa cpathipa merged commit 7c105de into linode:develop Sep 13, 2024
18 of 19 checks passed
@cpathipa cpathipa mentioned this pull request Sep 13, 2024
Merged
hkhalil-akamai pushed a commit that referenced this pull request Sep 13, 2024
@cpathipa @jaalah @hkhalil-akamai
feat: [M3-8326], [M3-8055] - Create Linode - Create Using Command Lin…
5a294fc 
…e A/B Test (#10906)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Create feature flag for DX tools A/B testing

* Add data attributes for DX tools for tracking

* Update Actions.test.tsx

* Test flag

* Add classname

* Add event emitters to the LD from DX tools

* update with correct keys

* Destructure tabs

* code cleanup

* Add event emitter to Integration and SDK tab resources.

* Add go and python code snippets

* Add Linode CLI Tab Selection

* Remove old ab test code

* Cleanup conditionals

* Add changeset

* Revert "Merge branch 'linode:develop' into develop"

This reverts commit bfed239, reversing
changes made to 342fd96.

* Reapply "Merge branch 'linode:develop' into develop"

This reverts commit 9e54b55.

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
hkhalil-akamai pushed a commit that referenced this pull request Sep 13, 2024
@cpathipa @jaalah @hkhalil-akamai
feat: [M3-8326], [M3-8055] - Create Linode - Create Using Command Lin…
33eb344 
…e A/B Test (#10906)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Create feature flag for DX tools A/B testing

* Add data attributes for DX tools for tracking

* Update Actions.test.tsx

* Test flag

* Add classname

* Add event emitters to the LD from DX tools

* update with correct keys

* Destructure tabs

* code cleanup

* Add event emitter to Integration and SDK tab resources.

* Add go and python code snippets

* Add Linode CLI Tab Selection

* Remove old ab test code

* Cleanup conditionals

* Add changeset

* Revert "Merge branch 'linode:develop' into develop"

This reverts commit bfed239, reversing
changes made to 342fd96.

* Reapply "Merge branch 'linode:develop' into develop"

This reverts commit 9e54b55.

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
@cpathipa cpathipa mentioned this pull request Sep 13, 2024
Merged
cpathipa added a commit that referenced this pull request Sep 13, 2024
@cpathipa
Fix broken cypress tests caused by - #10906 (#10936)
2ea71f4 
* code cleanup

* fix broken cypress tests for dx tools modal

* wrapping the test in describe block

* Update create-linode-view-code-snippet.spec.ts

* Code cleanup

* Flush ldClient after event fired

* flush after track event is fired

* Update GoSDKResources.tsx
@hkhalil-akamai hkhalil-akamai mentioned this pull request Sep 16, 2024
Merged
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
@cpathipa @jaalah @nikhagra-akamai
feat: [M3-8326], [M3-8055] - Create Linode - Create Using Command Lin…
6012ec4 
…e A/B Test (linode#10906)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Create feature flag for DX tools A/B testing

* Add data attributes for DX tools for tracking

* Update Actions.test.tsx

* Test flag

* Add classname

* Add event emitters to the LD from DX tools

* update with correct keys

* Destructure tabs

* code cleanup

* Add event emitter to Integration and SDK tab resources.

* Add go and python code snippets

* Add Linode CLI Tab Selection

* Remove old ab test code

* Cleanup conditionals

* Add changeset

* Revert "Merge branch 'linode:develop' into develop"

This reverts commit bfed239, reversing
changes made to 342fd96.

* Reapply "Merge branch 'linode:develop' into develop"

This reverts commit 9e54b55.

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
@cpathipa @jaalah @nikhagra-akamai
feat: [M3-8326], [M3-8055] - Create Linode - Create Using Command Lin…
a6b6af6 
…e A/B Test (linode#10906)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Create feature flag for DX tools A/B testing

* Add data attributes for DX tools for tracking

* Update Actions.test.tsx

* Test flag

* Add classname

* Add event emitters to the LD from DX tools

* update with correct keys

* Destructure tabs

* code cleanup

* Add event emitter to Integration and SDK tab resources.

* Add go and python code snippets

* Add Linode CLI Tab Selection

* Remove old ab test code

* Cleanup conditionals

* Add changeset

* Revert "Merge branch 'linode:develop' into develop"

This reverts commit bfed239, reversing
changes made to 342fd96.

* Reapply "Merge branch 'linode:develop' into develop"

This reverts commit 9e54b55.

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
@cpathipa @nikhagra-akamai
Fix broken cypress tests caused by - linode#10906 (linode#10936)
0de1527 
* code cleanup

* fix broken cypress tests for dx tools modal

* wrapping the test in describe block

* Update create-linode-view-code-snippet.spec.ts

* Code cleanup

* Flush ldClient after event fired

* flush after track event is fired

* Update GoSDKResources.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@hkhalil-akamai hkhalil-akamai hkhalil-akamai approved these changes

@dwiley-akamai dwiley-akamai Awaiting requested review from dwiley-akamai dwiley-akamai is a code owner automatically assigned from linode/frontend

@cliu-akamai cliu-akamai Awaiting requested review from cliu-akamai cliu-akamai was automatically assigned from linode/frontend-sdet

Assignees

@cpathipa cpathipa

Labels
Add'tl Approval Needed Waiting on another approval!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cpathipa @jaalah-akamai @jdamore-linode @hkhalil-akamai @jaalah