-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8549] β BSE tooltip copy update & add "Encrypt Volume" checkbox in Attach Volume drawer #10909
upcoming: [M3-8549] β BSE tooltip copy update & add "Encrypt Volume" checkbox in Attach Volume drawer #10909
Conversation
β¦'Encrypt Volume' checkbox in Attach Volume drawer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a checkbox in the edit drawer made sense to me because theoretically, in the future we could allow users to encrypt an unencrypted volume using PUT /v4/volumes/:id
Will there ever be a world where we'd allow the volume to be encrypted at the time of attaching? I'm wondering if it really makes sense to have a checkbox for this in the Attach drawer
Coverage Report: β
|
It's hypothetical right now but I think it would mostly come down to the specific API implementation. I surfaced this feedback to UX and Product though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out and context about having the checkbox in this drawer - thanks!
β
Encryption checkbox is present in the Attach drawer and is checked/not depending on encryption status of volume
β
Copy update looks good
β
Unit tests coverage looks good and passes
β¦checkbox in Attach Volume drawer (linode#10909)
Description π
This PR is quite similar to #10787.
Target release date ποΈ
9/16/24
Preview π·
How to test π§ͺ
Prerequisites
Point at the dev environment with the
blockstorage-encryption
tag on your accountVerification steps
Confirm the Attach Volume drawer (accessed from Volume landing page --> three-dot menu for a volume) has the BSE checkbox when the feature flag is on, and that the checkbox reflects the volume's encrypted status (i.e., encrypted volumes should have a checked disabled box, and unencrypted volumes should have an unchecked disabled box)
As an Author I have considered π€