Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8549] – BSE tooltip copy update & add "Encrypt Volume" checkbox in Attach Volume drawer #10909

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Sep 9, 2024

Description πŸ“

  • Minor tooltip copy update in Edit Volume drawer
  • Add disabled "Encrypt Volume" checkbox in Attach Volume drawer

This PR is quite similar to #10787.

Target release date πŸ—“οΈ

9/16/24

Preview πŸ“·

Before After
Screenshot 2024-09-09 at 1 26 33β€―PM Screenshot 2024-09-09 at 1 25 54β€―PM

How to test πŸ§ͺ

yarn test AttachVolumeDrawer.test.tsx

Prerequisites

Point at the dev environment with the blockstorage-encryption tag on your account

Verification steps

Confirm the Attach Volume drawer (accessed from Volume landing page --> three-dot menu for a volume) has the BSE checkbox when the feature flag is on, and that the checkbox reflects the volume's encrypted status (i.e., encrypted volumes should have a checked disabled box, and unencrypted volumes should have an unchecked disabled box)

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption label Sep 9, 2024
@dwiley-akamai dwiley-akamai self-assigned this Sep 9, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner September 9, 2024 17:31
@dwiley-akamai dwiley-akamai requested review from bnussman-akamai and carrillo-erik and removed request for a team September 9, 2024 17:31
Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a checkbox in the edit drawer made sense to me because theoretically, in the future we could allow users to encrypt an unencrypted volume using PUT /v4/volumes/:id

Will there ever be a world where we'd allow the volume to be encrypted at the time of attaching? I'm wondering if it really makes sense to have a checkbox for this in the Attach drawer

Copy link

github-actions bot commented Sep 9, 2024

Coverage Report: βœ…
Base Coverage: 86.4%
Current Coverage: 86.4%

@dwiley-akamai
Copy link
Contributor Author

Putting a checkbox in the edit drawer made sense to me because theoretically, in the future we could allow users to encrypt an unencrypted volume using PUT /v4/volumes/:id

Will there ever be a world where we'd allow the volume to be encrypted at the time of attaching? I'm wondering if it really makes sense to have a checkbox for this in the Attach drawer

It's hypothetical right now but I think it would mostly come down to the specific API implementation. I surfaced this feedback to UX and Product though!

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 10, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out and context about having the checkbox in this drawer - thanks!

βœ… Encryption checkbox is present in the Attach drawer and is checked/not depending on encryption status of volume
βœ… Copy update looks good
βœ… Unit tests coverage looks good and passes

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 10, 2024
@dwiley-akamai dwiley-akamai merged commit 28f6bca into linode:develop Sep 10, 2024
19 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8549-bse-copy-updates-and-attach-drawer branch September 10, 2024 20:48
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants