test: [M3-7123] - Cypress integration test for edit subnet flow #9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
jdamore-linode and
carrillo-erik
and removed request for
a team
|
I was able to verify that all 4 e2e test passed on my machine after running your PR locally ✅
|
carrillo-erik
approved these changes
Sep 28, 2023
|
Do we need to include a changeset for this? |
jdamore-linode
approved these changes
Sep 28, 2023
coliu-akamai
added
Approved
|
Thanks Erik and Joe! @carrillo-erik - I looked at other prs for tests, and they don't seem to include changesets for the tests themselves, so I didn't include one here. Will double check though! |
|
Added changeset as per new changeset types -- thanks Erik and Joe! |
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
How to test 🧪
Verify that tests pass:
yarn cy:run -s "cypress/e2e/core/vpc/vpc-details-page.spec.ts"