Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.105.0 - release → staging #9789

Merged
merged 39 commits into from
Oct 16, 2023
Merged

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 12, 2023

Cloud Manager

[2023-10-16] - v1.105.0

Added:

  • Statically Cache Marketplace Apps (#9732)
  • Link contact Support text in notices to support ticket modal (#9770)

Changed:

  • Comment out CS:GO app pending update (#9753)

Fixed:

  • Add Firewall and Linode Configuration success toast notifications (#9725)
  • Long drawer titles overlapping close icon (#9731)
  • Removed title prop forwarding on Modals/Dialogs (#9739)
  • Fixed the top spacing for the NodeBalancer empty state page (#9746)
  • Notice scroll-to-view behavior and styling regressions (#9755)
  • Display Database menu items in side nav and Create dropdown for permissioned users (#9762)
  • Customer success Hively overlap issue (#9776)
  • Inconsistent display of % in Linode Details MNTP legend (#9780)

Tech Stories:

  • Disable Sentry Performance Tracing (#9745)
  • Migrate Filesystem TextField Select to Autocomplete (#9752)
  • MUI v5 Migration - SRC > Features > Lish (#9774)

Tests:

  • Added Cypress integration test for Edit Subnet flow (#9728)
  • Cypress tests for VPC create flows (#9730)

Upcoming Features:

  • Subnet Unassign Linodes Drawer (#9703)
  • Add AGLB Route Delete Dialog (#9735)
  • Add Drag and Drop support to the Load Balancer Rules Table (#9736)
  • Make Reboot Linodes dismissible banner on VPC Details page unique for each VPC (#9743)
  • Showcase VPC feedback (#9751)
  • Persistent error messages for Region, Label, and Description fields in VPC Create flow (#9750)
  • Ability to choose resize types when resizing Linode (#9677)

API-v4

[2023-10-16] - v0.103.0

Added:

  • New payload option migration_type in ResizeLinodePayload and new event type linode_resize_warm_create (#9677)

jaalah-akamai and others added 30 commits October 2, 2023 14:01
## Description 📝
Allow for un-assigning Linodes from subnets.

## Major Changes 🔄
- Allow for Linodes can be batch unassigned
- Add unassigned Linodes to CSV in order to provide list for instances that need to be rebooted

## How to test 🧪
> **Note**
Unit / Integration Tests will be handled in a separate PR [M3-6771]

1. Ensure you have both customer tags applied (see me for details)
2. Ensure feature flag is enabled in environment
3. Point `env` variables to DEV and use incognito to hit local host
4. Go to VPC > Subnets and ensure you have some Linode configs in your subnet (if not, add them)
5. Otherwise, click actions menu "..." to `Unassign Linodes`
6. Selecting a linode config should show "Linodes to be Unassigned from Subnet (x)" with a list of Linodes selecting
    1. You should be able to undo selections in multiple ways via the UI
8. Downloading the CSV (no linodes assigned, 1+ linodes assigned, determine that CSV accurately reflects the linodes in the 'Linodes assigned to Subnet (x) list) (should have linode's ID, label, public ipv4 at minimum, may include more fields)
9. Double check that you can't unassign Linodes to a subnet if you don't have the permissions for that specific vpc


---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Hana Xu <hxu@akamai.com>
* add delete functionality

* Added changeset: Add AGLB Route Delete Dialog

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* Fix type error in SubnetUnassignLinodesDrawer

* Fix type error in SubnetUnassignLinodesDrawer
* Prevent forwarding the title prop to the html

* Added changeset: Removed `title` prop forwarding on Modals/Dialogs

* Address feedback
* disable tracing for now

* Added changeset: Disable Sentry Performance Tracing

* Update packages/manager/src/initSentry.ts

Fix spelling of `crutial` to  `crucial`

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…s page unique (#9743)

* make dismissible banner unique on vpc details page

* Added changeset: Make Reboot Linodes dismissible banner on VPC Details page unique for each VPC
* initial POC

* use `placeholderData` insted of `initalData`

* clean up and approve

* revert regions so unit tests don't fail

* fix flags import

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…ve DBaaS mocks (#9719)

* Remove account mocking behavior in `cy.visitWithLogin()`

* Include most recent product capabilities in account factory

* Remove DBaaS feature flag mocks, explicitly mock account to include Managed Databases capability

* Mock request to fetch DBaaS engine types
… in changeset.mjs (#9727)

* attempt

* sanitize backslashes

* escape backslash characters

* Update changeset.mjs

* updated comments on regex for better explanation
#9752)

* migrate from textfield to autocomplete

* remove un-needed optional chain

* Added changeset: Migrate Filesystem TextField Select to Autocomplete

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* Fix overlap caused by positioning

* Fix eslint perfectionist warnings

* Fix typo

* Added changeset: Long drawer titles overlapping close icon

* Use title padding with absolute positioning

* Uncomment unintentionally committed commented lines

* Use margin, which makes more sense
* initial drawer

* clean up

* add dynamic placeholder

* hook up api and validation

* close on success

* fix reseting

* start adding error handling

* validate more

* fix type

* updates to match mockups

* support tcp

* added inital e2e test

* more e2e testing

* all possible api errors are rendered now

* add test for tcp

* handle all error even if it's a TCP route

* handle all error even if it's a TCP route

* continue to build out / feedback

* how is this so complex

* spelling fixes

* add match type tooltip body

* small improvements

* only enable session stickiness for non-tcp routes

* only enable session stickiness for non-tcp routes

* remove `only`

* OMG! I think I'm on the right track with error handling

* OMG! I think I'm on the right track with error handling

* more validation work

* continue to work on validation

* continue to work on validation more

* tiny bit of clean up

* enforce service target percentage

* add `hostname` placeholder and add `disableClearable` to Match Type

* feedback @abailly-akamai

* improve styles of `X` button

* dial in validation and add italics

* more error handling and testing

* more strict validation

* okay, this is the best it's going to get

* validation feedback @tyler-akamai

* add min to ttl validation

* hide hostname for TCP rules, thank you @tyler-akamai

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* m3-7120

* Update subnets.ts

* changeset and some comments

* get rid of field errors after we change the field

* remove unnecessary file

* Added changeset: Ensure that error messages for region, label, and description on VPC Create flow do not incorrectly persist

* Update packages/manager/.changeset/pr-9750-fixed-1696365803471.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* abstract methods + make scrolling smooth

* remove rescroll after initial scroll

* simplified logic for scrolling on errors

---------

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Release v1.401.1 - staging → master
* add Tested to changeset types

* change Tested to tests for better phrasing
* Initial set up, open edit drawer action

* Update mock data, dynamic drawer display, and unit test

* Update tests to add TODOs and skip correctly

* Update payload for PUT request, update unit test

* Only include key in errorFields for a downstream cert type

* Add validation

* Fix schema

* Address feedback

* Re-enable cert and key fields; add cert field validation

* Add placeholder text to private key field

* Address Slack feedback

* Address feedback, but WIP validation

* Add type so validation triggers correctly; thanks @bnussman-akamai

* Address PR and UX feedback

* Fix failure in load-balancer-certificates.spec.ts due to label change
* edit subnet integration test

* Added changeset: Added Cypress integration test for Edit Subnet flow
* Initial commit - Notice improvements + fix linode create fix

* Styles & storybook update

* Added changeset: Fix issue where Notice should not be part of an error group

* Self review changes

* Cleanup

* Cleanup 2

* Feedback
## Description 📝
Address Showcase feedback

VPC Create
- Added remove X icon to default subnet label input.
- Changed button text from “Add Subnet” to “Add Another Subnet”.
- Button text is “Add a Subnet” when there are no subnets added.

VPC Details - Subnets
- Added `Unassign Linode` inline button to the Subnets table row which will open the Unassign Linodes drawer with the Linode pre-selected and the Linode select hidden.
  - Added helper text to the Unassign Linode drawer per the UX mocks and hide the helper text if the drawer is opened via inline Unassign Linode
- Updated Subnets table empty state text
- Pluralize Subnet action menu item text “Assign Linode” -> “Assign Linodes” and “Unassign Linode” -> “Unassign Linodes”.

## How to test 🧪
With a properly-tagged account or with the VPC feature flag on:
- Go to `/vpcs/create` and check the Subnets flow
  - You should be able to delete the first Subnet now
- Go to a VPC's details page
  - Create a Subnet and assign Linodes to it if you don't already have one
- Expand the collapsible table row and you should see `Unassign Linode` in the row
- Clicking that should bring up the Unassign Linodes drawer with that Linode pre-selected
- Unassign the Linode and ensure the Subnets table updates as normal

```
yarn test MultipleSubnetInput
yarn test SubnetNode
yarn test VPCCreate
yarn test SubnetLinodeRow
```

---------

Co-authored-by: Joe D'Amore <jdamore@linode.com>
* Initial commit - PR template udpate

* Initial commit - PR template udpate

* Update template

* Update some moar

* Address feedback

* Address feedback

* Address feedback

* Address feeback

* Address feeback

* Typo
* fixed spacing for NodeBalancer empty state

* Added changeset: Fixed the top spacing for the NodeBalancer empty state page

---------

Co-authored-by: TylerWJ <tylerwjones99@gmail.com>
…request, fix hanging (#9757)

* Perform clean up for domain resources

* Fetch Linode account info at Cypress start, mock account request using cached info

* Refactor Cypress test and command set up

* Refactor OAuth App tests into a single spec

* Fix test hanging by disabling new Chrome headless implementation
…ndabot (#9767)

Co-authored-by: Banks Nussman <banks@nussman.us>
* initial fixes

* re-add some text

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* feat: [M3-7185] - Add Drag and Drop support to the Rules Table

* Added changeset: Add Drag and Drop support to the Rules Table

* Persist reordered list in RulesTable

* Implement moveUp/MoveDown behaviors

* Integrate with update routs API

* remove local state and use API directly

* fix unit test

* fix unit test and console error

* Update packages/manager/src/features/LoadBalancers/LoadBalancerDetail/RulesTable.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update packages/manager/.changeset/pr-9736-upcoming-features-1696008733328.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* PR feedback

* Fix - Alignment for small and large screens

* Update RulesTable.tsx

* Adjust spacing

* Match column and header spacing correctly

* Update RulesTable.tsx

* update mock so test passes

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…9730)

* Change "VPC label" to "VPC Label" and "Subnet label" to "Subnet Label"

* Add tests to confirm UI flow when creating VPCs
…izing Linode (#9677)

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Alban Bailly <abailly@akamai.com>
jaalah-akamai and others added 3 commits October 11, 2023 14:39
---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
…dropdown for permissioned users (#9762)

* fix [UIE-6942]: dbaas menu

* Update packages/manager/.changeset/pr-9762-fixed-1696961275313.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/manager/src/components/PrimaryNav/PrimaryNav.test.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/manager/src/MainContent.test.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

---------

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: coliu-akamai <coliu@akamai.com>
@coliu-akamai coliu-akamai added the Release → Staging Pre-Release: Release → Staging label Oct 12, 2023
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 12, 2023 16:05
@coliu-akamai coliu-akamai removed the request for review from a team October 12, 2023 16:05
@coliu-akamai coliu-akamai self-assigned this Oct 12, 2023
@coliu-akamai coliu-akamai marked this pull request as draft October 12, 2023 16:05
@coliu-akamai coliu-akamai changed the base branch from develop to staging October 12, 2023 16:06
@coliu-akamai coliu-akamai marked this pull request as ready for review October 12, 2023 16:06
abailly-akamai
abailly-akamai previously approved these changes Oct 16, 2023
cpathipa
cpathipa previously approved these changes Oct 16, 2023
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dwiley-akamai dwiley-akamai merged commit a60dae8 into staging Oct 16, 2023
14 of 15 checks passed
dwiley-akamai added a commit that referenced this pull request Oct 17, 2023
Release v1.105.0 - `staging → master` (#9789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release → Staging Pre-Release: Release → Staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.