Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Reboot Linodes dismissible banner on VPC Details page unique #9742

Closed
wants to merge 1 commit into from
Closed

fix: make Reboot Linodes dismissible banner on VPC Details page unique #9742

wants to merge 1 commit into from

Conversation

coliu-akamai
Copy link
Contributor

Description 📝

Previously, the dismissible banner on the VPC details page was global, so dismissing it once dismissed this for every VPC. Added a unique identifier to the preference key so that the banner is unique for each VPC

image

How to test 🧪

  • Using the dev environment:
    • Create at least two VPCs
    • Assign at least one linode to each of the VPCs
    • Confirm that dismissing the banner that pops up on one of the VPC details page (image above) does not dismiss the banner on the other VPC's detail page page
  • Using MSW:
    • Close the dismissible banner on one of the mock VPC's detail pages
    • Confirm the banner remains closed on that detail page
    • Navigate to another VPC's detail page and confirm the banner still appears

@coliu-akamai coliu-akamai added the VPC Relating to VPC project label Oct 2, 2023
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 2, 2023 16:45
@coliu-akamai coliu-akamai self-assigned this Oct 2, 2023
@coliu-akamai coliu-akamai requested review from abailly-akamai and tyler-akamai and removed request for a team October 2, 2023 16:45
@coliu-akamai coliu-akamai changed the base branch from develop to release-v1.104.0 October 2, 2023 16:45
@coliu-akamai
Copy link
Contributor Author

closing this PR -- will be branching off of develop and then pointing to develop rather than the release branch!

@coliu-akamai coliu-akamai mentioned this pull request Oct 2, 2023
Merged
@coliu-akamai coliu-akamai deleted the make-vpc-dismissible-banner-unique branch October 3, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai Awaiting requested review from abailly-akamai abailly-akamai is a code owner automatically assigned from linode/frontend

@tyler-akamai tyler-akamai Awaiting requested review from tyler-akamai tyler-akamai is a code owner automatically assigned from linode/frontend

@dwiley-akamai dwiley-akamai Awaiting requested review from dwiley-akamai

Assignees

@coliu-akamai coliu-akamai

Labels
VPC Relating to VPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coliu-akamai