Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-7226] - Make Reboot Linodes dismissible banner on VPC Details page unique #9743

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: [M3-7226] - Make Reboot Linodes dismissible banner on VPC Details page unique #9743

merged 3 commits into from
Oct 3, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 2, 2023 •
edited
Loading

previous PR here: #9742
Switched to point to develop

Description 📝

Previously, the dismissible banner on the VPC details page was global, so dismissing it once dismissed this for every VPC. Added a unique identifier to the preference key so that the banner is unique for each VPC

image

How to test 🧪

  • Using the dev environment:
    • Create at least two VPCs
    • Assign at least one linode to each of the VPCs
    • Confirm that dismissing the banner that pops up on one of the VPC details page (image above) does not dismiss the banner on the other VPC's detail page page
  • Using MSW:
    • Close the dismissible banner on one of the mock VPC's detail pages
    • Confirm the banner remains closed on that detail page
    • Navigate to another VPC's detail page and confirm the banner still appears

@coliu-akamai coliu-akamai added the VPC Relating to VPC project label Oct 2, 2023
@coliu-akamai coliu-akamai self-assigned this Oct 2, 2023
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 2, 2023 17:06
@coliu-akamai coliu-akamai requested review from jdamore-linode and hana-akamai and removed request for a team October 2, 2023 17:06
hana-akamai
hana-akamai approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that dismissing the banner only dismisses it for the VPC instead of globally ✅

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 2, 2023
@coliu-akamai coliu-akamai changed the title Fix: make Reboot Linodes dismissible banner on VPC Details page unique fix: [M3-7226] - Make Reboot Linodes dismissible banner on VPC Details page unique Oct 3, 2023
dwiley-akamai
dwiley-akamai approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed unique as opposed to global dismissals ✅

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 3, 2023
@coliu-akamai coliu-akamai merged commit ebec3e3 into linode:develop Oct 3, 2023
11 checks passed
@coliu-akamai coliu-akamai deleted the make-vpc-banner-unique branch October 3, 2023 19:54
This was referenced Oct 12, 2023
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hana-akamai hana-akamai hana-akamai approved these changes

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

Assignees

@coliu-akamai coliu-akamai

Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coliu-akamai @dwiley-akamai @hana-akamai