Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7259] - Fix inconsistent display of % in Linode Details MNTP legend #9780

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Oct 10, 2023

Description 📝

Currently, on the Linode Details > Network tab, we display Monthly Network Transfer bar percents, labeled with a legend that looks like the following:

debian-us-sea (0.26 GB - 1%)
Global Pool Used (1 GB) - 1%

We should format these two legend labels consistently:

debian-us-sea (0.26 GB - 1%)
Global Pool Used (1 GB - 1%)

Changes 🔄

  • The percentage of the Global/DC-specific pool used is formatted in the same way that the percentage of the pool that the linode has used: [label] ([number] GB - [percent]%)

Preview 📷

Before After
Screenshot 2023-10-10 at 12 50 56 PM Screenshot 2023-10-10 at 1 08 25 PM

How to test 🧪

Prerequisites

  • Make sure DC-specific pricing feature flag is on.
  • If you do not have an existing linode on your account, create one.

Reproduction steps

  • In prod, go to a linode's details page and navigate to the Network tab.
  • Observe that the way we format the legend labels in the Monthly Network Transfer section is inconsistent -- in one case, we include the % inside the parentheses, and in another, it is after.

Verification steps

  • On this branch, go to a linode's details page and navigate to the Network tab.
  • Observe that the way we format the legend labels in the Monthly Network Transfer section is consistent.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this Oct 10, 2023
@mjac0bs mjac0bs marked this pull request as ready for review October 10, 2023 20:23
@mjac0bs mjac0bs requested a review from a team as a code owner October 10, 2023 20:23
@mjac0bs mjac0bs requested review from bnussman-akamai and abailly-akamai and removed request for a team October 10, 2023 20:23
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching! change look good

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Screenshot 2023-10-10 at 4 29 40 PM

@mjac0bs mjac0bs added DC-Specific Pricing Bug Fixes for regressions or bugs Approved Multiple approvals and ready to merge! labels Oct 10, 2023
@mjac0bs mjac0bs merged commit 10996a2 into linode:develop Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs DC-Specific Pricing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants