fix: #125 - remove debug dependency from lockfile-lint-api, remove 'u…

…rl' dependency, bump engine to v10 (#127) BREAKING CHANGE: Dropped support for Node.js 8.x - now supported versions start at Node.js 10.x
lirantal · Jun 11, 2022 · b4a8143 · b4a8143
1 parent 18c6ae0
commit b4a8143
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 15 deletions.
diff --git a/packages/lockfile-lint-api/package.json b/packages/lockfile-lint-api/package.json
@@ -4,7 +4,7 @@
   "description": "Lint an npm or yarn lockfile to analyze and detect issues",
   "main": "index.js",
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=10.0.0"
   },
   "scripts": {
     "lint": "eslint .",
@@ -49,7 +49,6 @@
   },
   "dependencies": {
     "@yarnpkg/parsers": "^3.0.0-rc.6",
-    "debug": "^4.1.1",
     "object-hash": "^2.0.1"
   },
   "devDependencies": {

diff --git a/packages/lockfile-lint-api/src/validators/ValidateHost.js b/packages/lockfile-lint-api/src/validators/ValidateHost.js
@@ -1,16 +1,16 @@
 'use strict'
 
-const {URL} = require('url')
-const debug = require('debug')('lockfile-lint-api')
 const {REGISTRY} = require('../common/constants')
 
+const noop = () => {}
 module.exports = class ValidateHost {
-  constructor ({packages} = {}) {
+  constructor ({packages, debug = noop} = {}) {
     if (typeof packages !== 'object') {
       throw new Error('expecting an object passed to validator constructor')
     }
 
     this.packages = packages
+    this.debug = debug
   }
 
   validate (hosts, options) {
@@ -41,7 +41,7 @@ module.exports = class ValidateHost {
               hostValue = parsedHost.host
             }
           } catch (error) {
-            debug(`failed parsing a URL object from given host value so using as is: ${host}`)
+            this.debug(`failed parsing a URL object from given host value so using as is: ${host}`)
           }
 
           return hostValue
@@ -50,7 +50,7 @@ module.exports = class ValidateHost {
         const isPassing = allowedHosts.includes(packageResolvedURL.host)
         if (!isPassing) {
           if (!packageResolvedURL.host && options && options.emptyHostname) {
-            debug(`detected empty hostname but allowing because emptyHostname is not false`)
+            this.debug(`detected empty hostname but allowing because emptyHostname is not false`)
           } else {
             validationResult.errors.push({
               message: `detected invalid host(s) for package: ${packageName}\n    expected: ${allowedHosts}\n    actual: ${

diff --git a/packages/lockfile-lint-api/src/validators/ValidateHttps.js b/packages/lockfile-lint-api/src/validators/ValidateHttps.js
@@ -1,7 +1,5 @@
 'use strict'
 
-const {URL} = require('url')
-
 const HTTPS_PROTOCOL = 'https:'
 
 module.exports = class ValidateHttps {

diff --git a/packages/lockfile-lint-api/src/validators/ValidatePackageNames.js b/packages/lockfile-lint-api/src/validators/ValidatePackageNames.js
@@ -1,7 +1,5 @@
 'use strict'
 
-const {URL} = require('url')
-
 module.exports = class ValidatePackageNames {
   constructor ({packages} = {}) {
     if (typeof packages !== 'object') {

diff --git a/packages/lockfile-lint-api/src/validators/ValidateScheme.js b/packages/lockfile-lint-api/src/validators/ValidateScheme.js
@@ -1,7 +1,5 @@
 'use strict'
 
-const {URL} = require('url')
-
 module.exports = class ValidateProtocol {
   constructor ({packages} = {}) {
     if (typeof packages !== 'object') {

diff --git a/packages/lockfile-lint/package.json b/packages/lockfile-lint/package.json
@@ -6,7 +6,7 @@
     "lockfile-lint": "./bin/lockfile-lint.js"
   },
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=10.0.0"
   },
   "scripts": {
     "lint": "eslint .",

diff --git a/packages/lockfile-lint/src/validators/index.js b/packages/lockfile-lint/src/validators/index.js
@@ -45,7 +45,7 @@ function ValidateHostManager ({path, type, validatorValues, validatorOptions}) {
 
   const parser = new ParseLockfile(options)
   const lockfile = parser.parseSync()
-  const validator = new ValidateHost({packages: lockfile.object})
+  const validator = new ValidateHost({packages: lockfile.object, debug: require('debug')('lockfile-lint')})
   const validationResult = validator.validate(validatorValues, validatorOptions)
 
   // Check if some of the errors are for allowed URLs and filter those out