-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #125 - remove debug dependency from lockfile-lint-api #127
fix #125 - remove debug dependency from lockfile-lint-api #127
Conversation
dc34bdc
to
721b878
Compare
…move 'url' dependency, bump engine to v10
721b878
to
d84296a
Compare
@lirantal Before I merge this, can you confirm it's ok to stop supporting node.js version 8? I think it's been dead long enough, but maybe there's reasons? |
A few observations here:
|
module.exports = class ValidateHost { | ||
constructor ({packages} = {}) { | ||
constructor ({packages, debug = noop} = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noop
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noop by default, debug if passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok my bad. I missed that you have actually defined it here const noop = () => {}
a few lines before :-)
Yes, the CLI has a lot of other dependencies and for now I'm focusing on narrowing down lockfile-lint-api to a minimal scope of outside requirements to make it super easy to tightly secure with lavamoat policy or even run in a compartment with lockdown.
Yes, just api for now. Debug is a good thing and the package that uses TTY anyway does not need to be rid of it. I might pursue removing dependencies and builtin use from the CLI later, but that's outside the scope I was ready to tackle now.
Yes, it'd be the second breaking change I merge, so the major version is definitely going up. |
All sounds good to me :-) |
Just getting rid of a dependency that, while barely used, pulls in a bunch of requirements. Here's an overview:
This is also contributing to the progress on #123 by getting rid of tty and process requirements
BREAKING:
bumped engine to v10 to remove all
const {URL} = require('url')
I saw semantic-release is used, so this may need to be split into two conventional commits