Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Refactoring of NativeCalls #140

Closed
lucaneg opened this issue Oct 29, 2021 · 0 comments · Fixed by #158
Closed

[FEATURE REQUEST] Refactoring of NativeCalls #140

lucaneg opened this issue Oct 29, 2021 · 0 comments · Fixed by #158
Assignees
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🎆 type:feature New feature or request 🛠 type:refactoring Refactoring of the codebase
Milestone

Comments

@lucaneg
Copy link
Member

lucaneg commented Oct 29, 2021

Description
While the idea of supporting language constructs through NativeCalls seemed appropriate, the only difference from "regular" expressions is that it was easier to support n-ary expressions. We should remove NativeCalls entirely and transform them into Expression instances.

After this, we should add a generic NaryExpression that serves as a base class for what we are now supporting through native calls.

As a final note, to make expression evaluation more generic, we should also add the option of changing the evaluation order of the parameters of an expression: imposing left-to-right recursive evaluation, as well right-before-left evaluation in assignments, is too restrictive.

@lucaneg lucaneg added 🎆 type:feature New feature or request 🛠 type:refactoring Refactoring of the codebase ‼ priority:p1 Priority planning - level 1 labels Oct 29, 2021
@lucaneg lucaneg added this to the 0.1b3 milestone Oct 29, 2021
@lucaneg lucaneg self-assigned this Oct 29, 2021
@lucaneg lucaneg removed this from the 0.1b3 milestone Oct 29, 2021
@lucaneg lucaneg added this to the 0.1b4 milestone Jan 3, 2022
@lucaneg lucaneg removed the 🎆 type:feature New feature or request label Jan 11, 2022
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Jan 12, 2022
@lucaneg lucaneg added the 🎆 type:feature New feature or request label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🎆 type:feature New feature or request 🛠 type:refactoring Refactoring of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant