Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Re-enable short-circuiting #165

Closed
lucaneg opened this issue Jan 21, 2022 · 0 comments · Fixed by #167
Closed

[FEATURE REQUEST] Re-enable short-circuiting #165

lucaneg opened this issue Jan 21, 2022 · 0 comments · Fixed by #167
Assignees
@lucaneg
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🎆 type:feature New feature or request
Milestone
0.1b5

Comments

@lucaneg
Copy link
Member

lucaneg commented Jan 21, 2022

Description
Following #140, short-circuit logic (made possible by #29) is no longer possible. We should pass the expressions lattice also to methods of subclasses for them to access what has been computed on sub-expressions.
@lucaneg lucaneg added 🎆 type:feature New feature or request ‼ priority:p1 Priority planning - level 1 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms labels Jan 21, 2022
@lucaneg lucaneg added this to the 0.1b5 milestone Jan 21, 2022
@lucaneg lucaneg self-assigned this Jan 21, 2022
lucaneg added a commit that referenced this issue Jan 24, 2022
@lucaneg
#165 propagating the StatementStore of expressions
cc3212c
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Jan 24, 2022
@lucaneg lucaneg mentioned this issue Jan 24, 2022
Merged
lucaneg added a commit that referenced this issue Jan 25, 2022
@lucaneg
#165 passing expressions to recursive evaluations
e90b10b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaneg lucaneg

Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🔍 scope:analysis Work regarding abstract domains or fixpoint algorithms 🎆 type:feature New feature or request
Projects
None yet
Milestone
0.1b5
Development

Successfully merging a pull request may close this issue.

Restoring short-circuit capabilities lisa-analyzer/lisa
1 participant
@lucaneg