Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Remove offset from CodeNode #296

Closed
lucaneg opened this issue Dec 4, 2023 · 0 comments · Fixed by #297
Closed

[FEATURE REQUEST] Remove offset from CodeNode #296

lucaneg opened this issue Dec 4, 2023 · 0 comments · Fixed by #297
Assignees
@lucaneg
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏨 scope:infrastructure Work regarding the general infrastructure and functioning of LiSA 🎆 type:feature New feature or request
Milestone
0.1

Comments

@lucaneg
Copy link
Member

lucaneg commented Dec 4, 2023

Description
The unique purpose of offsets right now is to have a quick way of grabbing a numeric identifier out of a node. This is used only for creating serializable graphs. Offsets have the downside that whenever one clones a node it must remember to propagate the offset, and that sometimes exceptions are raised if this is not appropriately handled.
@lucaneg lucaneg added 🎆 type:feature New feature or request ‼ priority:p1 Priority planning - level 1 🏨 scope:infrastructure Work regarding the general infrastructure and functioning of LiSA labels Dec 4, 2023
@lucaneg lucaneg added this to the 0.1 milestone Dec 4, 2023
@lucaneg lucaneg self-assigned this Dec 4, 2023
lucaneg added a commit that referenced this issue Dec 4, 2023
@lucaneg
Removing offset from nodes #296
6586dd7
@lucaneg lucaneg mentioned this issue Dec 4, 2023
Merged
@lucaneg lucaneg added the 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet label Dec 5, 2023
@lucaneg lucaneg mentioned this issue Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaneg lucaneg

Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏨 scope:infrastructure Work regarding the general infrastructure and functioning of LiSA 🎆 type:feature New feature or request
Projects
LiSA
Archived in project
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Offset removal lisa-analyzer/lisa
1 participant
@lucaneg