Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Restore Statement.compareTo() #298

Closed
lucaneg opened this issue Dec 7, 2023 · 0 comments · Fixed by #299
Closed

[FEATURE REQUEST] Restore Statement.compareTo() #298

lucaneg opened this issue Dec 7, 2023 · 0 comments · Fixed by #299
Assignees
@lucaneg
Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏨 scope:infrastructure Work regarding the general infrastructure and functioning of LiSA 🏛 scope:program-structure Work regarding the program structure 🎆 type:feature New feature or request
Milestone
0.1

Comments

@lucaneg
Copy link
Member

lucaneg commented Dec 7, 2023

Description
Following #296, Statement.compareTo() only compares the location of the statements. This should be transformed to a full comparison of the fields to prevent statements from disappearing from sorted collections when they shouldn't.
@lucaneg lucaneg added 🎆 type:feature New feature or request 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet ‼ priority:p1 Priority planning - level 1 🏛 scope:program-structure Work regarding the program structure 🏨 scope:infrastructure Work regarding the general infrastructure and functioning of LiSA labels Dec 7, 2023
@lucaneg lucaneg added this to the 0.1 milestone Dec 7, 2023
@lucaneg lucaneg self-assigned this Dec 7, 2023
lucaneg added a commit that referenced this issue Dec 7, 2023
@lucaneg
Restoring compareTo()'s #298
8a7caa9
@lucaneg lucaneg mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaneg lucaneg

Labels
‼ priority:p1 Priority planning - level 1 🎊 resolution:resolved Bug or feature resolved - might not have been merged to master yet 🏨 scope:infrastructure Work regarding the general infrastructure and functioning of LiSA 🏛 scope:program-structure Work regarding the program structure 🎆 type:feature New feature or request
Projects
LiSA
Archived in project
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Restoring compareTo()'s lisa-analyzer/lisa
1 participant
@lucaneg