-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Edge on Windows 10 #15
Conversation
The failing Travis build is giving me this error:
It seems to be isolated to Travis, since |
Hi, it works so far. But the "Edge Browser" doesn't close automatically after the test like Chrome or Firefox. Is there a solution? Thomas |
This is a known bug with karma-edge-launcher. It relies on edge-launcher which does not seem to close Edge after the calling process is killed (see MicrosoftEdge/edge-launcher#21). By the way, I would appreciate help on fixing the Travis error about missing CHROME_BIN if you have any ideas. |
Thanks for merging! |
You are welcome |
Fixes #13. This uses my karma-edge-launcher plugin. Since Edge is a UWP app and not a traditional exe file, this locates a launcher (edge-launcher) instead of the browser itself.
Notes
node_modules
), I had to add some extra code toindex.js
to ignore Edge on older versions of Windows and other operating systems.os.release()
reports10.x
. It's also worth noting that AppVeyor is using Windows Server.