Fix using karma-edge-launcher on local tests #963
Conversation
|
@nickmccurdy, I'm a little hesitant to switch away from "karma-detect-browsers" to your fork, as we release quite often. What's blocking integration of your branch into karma-detect-browsers (assuming you sent them a PR)? |
|
That's a good point, you might want to wait. I was intending for it to point to my fork temporarily, as I do have a PR open. Its build is failing, and I haven't figured out why yet (it seems like a Travis-specific issue since my local tests passed). |
|
Ok, closing this for now. |
|
karma-detect-browsers has merged in my pull request, and now supports karma-edge-launcher as of version 2.2.0. |
|
I'm waiting for this issue to be fixed: litixsoft/karma-detect-browsers#17 Then I'll start a new pull request (or ask you to reopen this one if you prefer). |
|
I've reopened this one for you. Let me know when it's all good to go 👍 |
|
Waiting on a fix for litixsoft/karma-detect-browsers#17. |
|
@nickmccurdy, please rebase when you get a chance. |
nickserv
force-pushed
the
edge_testing
branch
from
b2e1fda
to
122aea3
Compare
|
@nickmccurdy when you are ready, let me know how to proceed. |
nickserv
force-pushed
the
edge_testing
branch
from
f2936d9
to
f831f5d
Compare
nickserv
changed the title
|
Sorry for the delay. I rebased the fix, it should be good now. |
|
updated code to use functional style - as is convention in the rest of the project. |
|
Good point, it's simpler with |
* develop: v6.1.5 chore(package): update snyk to version 1.21.2 (#980) chore(package): update snyk to version 1.21.1 (#979) fix: kill nightmare if response.code not 200 or doc is not a respec doc (#977) chore(fetch): patch to latest chore(package): update deps chore(CHANGELOG): regenerate fix: allow karma-edge-launcher on local tests (#963) chore(package): update snyk to version 1.20.0 (#974)
Results
Notes