Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.4 phar and box build config #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add 1.4 phar and box build config #82

wants to merge 2 commits into from

Conversation

ioleo
Copy link
Collaborator

@ioleo ioleo commented Sep 26, 2016 •
edited
Loading

Fixes #81

  • built current 1.4 version phar with box-project/box2
  • added box.json build config
  • (misc) added phpstorm project dir .idea to gitignore file

To build new phar (assuming we have box installed globally in our system) just go to fastest project dir and command box build

tommy-muehle
tommy-muehle reviewed Sep 27, 2016
View reviewed changes
Copy link

@tommy-muehle tommy-muehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tip. The ".idea" entry should be in your global .gitignore because every project needs this.

@ioleo
Copy link
Collaborator Author

ioleo commented Sep 27, 2016

@tommy-muehle what do you mean? it is in the root project directory

@tommy-muehle
Copy link

@loostro
You can define entries which apply to all git projects in your global .gitignore. So that you doesnt define it everytime in the project .gitignore. See here for more details.

@ioleo
Copy link
Collaborator Author

ioleo commented Sep 27, 2016

Thanks. I didn't know that 👍

@ioleo
Copy link
Collaborator Author

ioleo commented Sep 27, 2016

@liuggio waiting for review

@DonCallisto DonCallisto force-pushed the master branch 2 times, most recently from 2d76843 to b1cadad Compare December 1, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommy-muehle tommy-muehle tommy-muehle left review comments

@seyfer seyfer seyfer approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ioleo @tommy-muehle @seyfer @loostro