Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metadata updates async and throw after timeout #1168

Merged
merged 16 commits into from
Jul 10, 2024
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jun 20, 2024

this makes metadata, name and attribute updates async and queues subsequent requests until a response has been received.

Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: c1ca01b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO marked this pull request as ready for review July 2, 2024 15:43
Copy link
Contributor

github-actions bot commented Jul 2, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.76 KB (+0.62% 🔺)
dist/livekit-client.umd.js 86.58 KB (+0.58% 🔺)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lukasIO lukasIO merged commit 8a5cbed into main Jul 10, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/async-metadata branch July 10, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants