Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience method setAttribute to update a single key/value pair #1181

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

davidzhao
Copy link
Member

No description provided.

@davidzhao davidzhao requested a review from lukasIO July 5, 2024 20:48
Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: c946c07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 5, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.28 KB (+0.04% 🔺)
dist/livekit-client.umd.js 86.11 KB (+0.04% 🔺)

@lukasIO
Copy link
Contributor

lukasIO commented Jul 6, 2024

Some thoughts:

  • with Make metadata updates async and throw after timeout #1168 still pending, we'll be in a situation where setting multiple attributes after one another will take a lot longer (as it waits for server ack)
  • I'd be inclined to offer one primary way to update attributes, the current api with setAttributes({myAttr}); seems to be as concise (if not more) than explicitly requiring users to set the key separately as a string with setAttribute('myAttr', myAttr) 🤔

@lukasIO lukasIO merged commit 3a54bf6 into main Jul 9, 2024
@lukasIO lukasIO deleted the single-set-attribute branch July 9, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants