Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery,pm,server: Additional checks to avoid nil pointer errors caused by unexpected orchestrator configurations #1818

Merged
merged 4 commits into from
Mar 29, 2021
Merged

discovery,pm,server: Additional checks to avoid nil pointer errors caused by unexpected orchestrator configurations #1818

merged 4 commits into from
Mar 29, 2021

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented Mar 26, 2021 •
edited
Loading

What does this pull request do? Explain your changes. (required)

Specific updates (required)

  • Return an error from validateTicketParams() if the provided ticketParams argument is nil
  • Skip an orchestrator during latency / stake weight selection if it has no ticket params
  • Skip caching an orchestrator to the DB if it has no ETH address

How did you test each of these updates (required)

  • Unit tests
  • Reproduce crash cases and check they don't happen again.

Does this pull request close any open issues?

Checklist:

kyriediculous added a commit that referenced this pull request Mar 26, 2021
@kyriediculous
pending changelog entry for #1818
b0ef99c
@kyriediculous kyriediculous changed the title discovery,pm,server: additional check in on-chain mode to avoid nil pointer errors discovery,pm,server: Additional checks to avoid nil pointer errors caused by unexpected orchestrator configurations Mar 26, 2021
@kyriediculous kyriediculous requested a review from yondonfu March 26, 2021 20:12
yondonfu
yondonfu requested changes Mar 26, 2021
View reviewed changes
server/selection.go Outdated Show resolved Hide resolved
@kyriediculous kyriediculous requested a review from yondonfu March 26, 2021 22:59
@yondonfu yondonfu marked this pull request as ready for review March 27, 2021 15:02
yondonfu
yondonfu approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@kyriediculous kyriediculous merged commit 0e42586 into master Mar 29, 2021
@kyriediculous kyriediculous deleted the nv/nil-checks branch March 29, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyriediculous @yondonfu