Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fototoon close icon missing in small screens #213

Closed
vjrj opened this issue May 16, 2018 · 5 comments
Closed

Fototoon close icon missing in small screens #213

vjrj opened this issue May 16, 2018 · 5 comments
Labels
bug
Milestone
v1.1

Comments

@vjrj
Copy link
Contributor

vjrj commented May 16, 2018

It seems that the close icon is missing and does not works in Android.

https://imgur.com/a/fapv550

Thanks/merci!
@llaske
Copy link
Owner

llaske commented May 16, 2018

What is the size of your screen ? Could you send a full screen capture ?

@vjrj
Copy link
Contributor Author

vjrj commented May 16, 2018

Screen: 1080x1920

https://imgur.com/a/lg6HfMq

@llaske llaske added the bug label May 16, 2018
@llaske
Copy link
Owner

llaske commented May 16, 2018

Unfortunately Sugarizer is not really adapted today to smartphone screens.
BTW it will be better to do a CSS media query to avoid hiding the Stop button in any case else it's just impossible to go back to home view.

@llaske llaske changed the title fototoon close icon missing in android Fototoon close icon missing in small screens May 16, 2018
@llaske
Copy link
Owner

llaske commented Oct 21, 2018

Source code for Fototoon activity is located here https://github.com/llaske/sugarizer/tree/dev/activities/Fototoon.activity

AndreaGon added a commit to AndreaGon/sugarizer that referenced this issue Nov 9, 2018
@AndreaGon
Fix llaske#213: Fototoon stop button icon
ff5479e 
Changed min-width so icons will only hide when screen size becomes too small.
llaske added a commit that referenced this issue Nov 9, 2018
@llaske
Merge pull request #233 from AndreaGon/patch-2
c4853c0 
Fix #213 Fototoon stop icon fix
@llaske
Copy link
Owner

llaske commented Nov 9, 2018

Fixed in c4853c0

@llaske llaske added this to the v1.1 milestone Nov 9, 2018
@llaske llaske closed this as completed in 354b53e Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@vjrj @llaske