Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #213 Fototoon stop icon fix #233

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Fix #213 Fototoon stop icon fix #233

merged 2 commits into from
Nov 9, 2018

Conversation

AndreaGon
Copy link
Contributor

Added CSS media query. Also hid splitbar for smartphone mode (on desktop mode it shows.)

Added CSS media query. Also hid splitbar for smartphone mode (on desktop mode it shows.)
@llaske
Copy link
Owner

llaske commented Nov 8, 2018

It solve the issue but it's too aggressive, you start reducing size and hiding items thought there is still enough room in the toolbar. You should only hide item when the size become too small.

Changed min-width so icons will only hide when screen size becomes too small.
@AndreaGon AndreaGon changed the title Fix #213 Fototoon stop button icon fix Fix #213 Fototoon stop icon fix: Changed min-width value Nov 9, 2018
@AndreaGon AndreaGon changed the title Fix #213 Fototoon stop icon fix: Changed min-width value Fix #213 Fototoon stop icon fix Nov 9, 2018
@llaske
Copy link
Owner

llaske commented Nov 9, 2018

That's very good now. Thanks.

@llaske llaske merged commit c4853c0 into llaske:dev Nov 9, 2018
@AndreaGon AndreaGon deleted the patch-2 branch November 17, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants