Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Record activity to see picture in real time #266

Closed
llaske opened this issue Jan 24, 2019 · 11 comments
Closed

Improve Record activity to see picture in real time #266

llaske opened this issue Jan 24, 2019 · 11 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@llaske
Copy link
Owner

llaske commented Jan 24, 2019

In the Record activity (except on iOS/Android), when you take a picture, you don't see a preview of the picture. You just see a rolling spinner.

capture d ecran 2019-01-24 a 15 45 07

Conversely, the QR Code activity allow user to take a picture of QR Code and provide a real time preview of the picture.
The idea is to improve the Record activity to display a real time preview of the picture.

The source code of the Record activity is here: https://github.com/llaske/sugarizer/tree/master/activities/Record.activity
The source code of the QR Code activity is here: https://github.com/llaske/sugarizer/tree/master/activities/QRCode.activity

@quozl
Copy link

quozl commented Jan 24, 2019

On Chrome OS with Sugarizer v1.1 and Record, I see preview. The preview is right-way up. When taking photograph, it is upside down. I did not check for left-right swap.

@llaske
Copy link
Owner Author

llaske commented Jan 24, 2019

Oh really? Guess it's a Chrome OS integrated feature. Nothing in the source code today implement this. Do you have the same thing with QR Code activity?

@quozl
Copy link

quozl commented Jan 24, 2019

Thanks. Tested again.

  • QR Code activity preview is right-way up and is left-right swapped (good); the QR is correctly read, but not shown, so I don't know if it is upside down.
  • Record activity preview is right-way up and is left-right swapped (good), but the draft photograph and kept photograph are upside down (not as good).

In both cases, Camera privacy light remains on after activity is stopped.

@niravasher
Copy link

Hey this issue is solved right? @quozl @llaske . If not what is kept photograph and draft photograph? and how can I solve this issue?

@quozl
Copy link

quozl commented Jan 28, 2019

Sugarizer is multi-platform. Problem is on some platforms, as I've proved by saying not Chrome OS. kept and draft refer to the continued existence of the photograph.

@llaske
Copy link
Owner Author

llaske commented Jan 29, 2019

@niravasher, this issue is still open.
@quozl mentioned the specific way of working on Chrome OS but it's very specific to this platforms. The fix is still need on browsers (Chrome/Firefox/Safari) for all other platforms (Linux/Windows/MacOS).
As I said, to solve this issue, the idea is to adapt code from QRCode activity into Record activity.

@ashish0910
Copy link
Contributor

@llaske can I work on this ?

@llaske
Copy link
Owner Author

llaske commented Feb 13, 2019

@ashish0910 sure.

ashish0910 added a commit to ashish0910/sugarizer that referenced this issue Feb 14, 2019
@ashish0910
Copy link
Contributor

@llaske please review #275

@ashish0910
Copy link
Contributor

@llaske now added support for Firefox 65 and Chrome 72 .tested on electron on macosx , chrome and Firefox also . #275

llaske added a commit that referenced this issue Feb 21, 2019
@llaske llaske added the to be release Fixed, to be release label Feb 21, 2019
@llaske llaske added this to the v1.2 milestone Apr 10, 2019
@llaske
Copy link
Owner Author

llaske commented Sep 26, 2019

Closed in dd3c58d

@llaske llaske closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants