Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #266 fix #275

Merged
merged 11 commits into from
Feb 21, 2019
Merged

issue #266 fix #275

merged 11 commits into from
Feb 21, 2019

Conversation

ashish0910
Copy link
Contributor

@ashish0910 ashish0910 commented Feb 14, 2019 •
edited
Loading

Preview is added while taking a picture in Record activity .

@ashish0910 ashish0910 mentioned this pull request Feb 14, 2019
Closed
@llaske
Copy link
Owner

llaske commented Feb 14, 2019

Don't work on my side: no preview displayed in Chrome 72 and do an error on console in Firefox 65.
What's your testing environment?

@ashish0910
Copy link
Contributor Author

ashish0910 commented Feb 15, 2019 •
edited
Loading

@llaske now added support for Firefox 65 and Chrome 72 . Earlier was tested on electron on macosx but now tested on chrome and Firefox also .

@llaske
Copy link
Owner

llaske commented Feb 16, 2019

It's now work on Chrome but not on Firefox: the photo is displayed but it never recorded. There is an error on console:

  Recorder state changed: recording recordrtc.js:705:17
  Initialized recorderType: MediaStreamRecorder for output-type: video recordrtc.js:99:13
  Stopped recording video stream. recordrtc.js:125:13
  Recorder state changed: stopped recordrtc.js:705:17
video/webm -> 217 Bytes recordrtc.js:166:17
  La ressource média data:video/webm;base64,GkXfowEAAAAAAAAfQoaBAUL3gQFC8oEEQvOBCEKChHdlYm1Ch4ECQoWBAhhTgGcB/////////xFNm3QBAAAAAAAAABVJqWYBAAAAAAAASSrXsYMPQkBEiYgAAAAAAAAAAE2AmFFUbXV4aW5nQXBwTGliV2ViTS0wLjAuMVdBmVFUd3JpdGluZ0FwcExpYldlYk0tMC4wLjEWVK5rAQAAAAAAADWuAQAAAAAAACzXgQFzxYQ+kgeYJYaIg1ZQOIOBAYaFVl9WUDjgAQAAAAAAAAiwggKAuoIB4A== n’a pu être décodée. index.html
  La ressource multimédia data:video/webm;base64,GkXfowEAAAAAAAAfQoaBAUL3gQFC8oEEQvOBCEKChHdlYm1Ch4ECQoWBAhhTgGcB/////////xFNm3QBAAAAAAAAABVJqWYBAAAAAAAASSrXsYMPQkBEiYgAAAAAAAAAAE2AmFFUbXV4aW5nQXBwTGliV2ViTS0wLjAuMVdBmVFUd3JpdGluZ0FwcExpYldlYk0tMC4wLjEWVK5rAQAAAAAAADWuAQAAAAAAACzXgQFzxYQ+kgeYJYaIg1ZQOIOBAYaFVl9WUDjgAQAAAAAAAAiwggKAuoIB4A== n’a pas pu être décodée, erreur : Error Code: NS_ERROR_DOM_MEDIA_METADATA_ERR (0x806e0006)

Plus, could you remove package.json and package-lock.json from your PR.

@ashish0910
Copy link
Contributor Author

@llaske now it shall work on all platforms.

@llaske
Copy link
Owner

llaske commented Feb 17, 2019

Unfortunately I've got the same issue on Firefox.

@ashish0910
Copy link
Contributor Author

ashish0910 commented Feb 18, 2019 •
edited
Loading

@llaske Works perfectly on my Firefox without any error on console . can you please try again 2-3 times as the error you were getting will be solved by just restarting your browser. It is a issue in Firefox browser. ref - https://stackoverflow.com/questions/44780856/firefox-html5-audio-media-resource-could-not-be-decoded-onmediasinkaudioerror

sugar

@llaske
Copy link
Owner

llaske commented Feb 19, 2019

Hmmm. Seems to works now. Strange.
BTW there is another issue: the security popup is shown two times (like in your video). Could you fix that?

@ashish0910
Copy link
Contributor Author

@llaske everything works perfectly now .

llaske
llaske reviewed Feb 20, 2019
View reviewed changes
activities/Record.activity/js/activity.js Outdated
if(navigator.getUserMedia){
navigator.getUserMedia({video:true},handleVideo,videoError);
}
// navigator.getUserMedia = navigator.getUserMedia || navigator.webkitGetMedia || navigator.mozGetUserMedia || navigator.msGetUserMedia || navigator.oGetUserMedia ;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must not leave commented code

@llaske
Copy link
Owner

llaske commented Feb 20, 2019

Nice. It works now.
Please remove commented code.

@ashish0910
Copy link
Contributor Author

done

@llaske llaske merged commit 25e28a2 into llaske:dev Feb 21, 2019
@llaske
Copy link
Owner

llaske commented Feb 21, 2019

Good work. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llaske llaske llaske left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashish0910 @llaske