Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tutorial for Clock Activity #512

Merged
merged 11 commits into from
Dec 21, 2019
Merged

Add Tutorial for Clock Activity #512

merged 11 commits into from
Dec 21, 2019

Conversation

AndreaGon
Copy link
Contributor

Clock Activity should now have a tutorial:

clock

Copy link
Owner

@llaske llaske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. See my comments on the review.

Could you also add a popup to describe the content of the clock: the meaning of each hand (red, blue, green)?

Yes you're right you don't need to translate text because I'm usually change the text and I think it's better to let native language speakers to translate in their own language.

activities/Clock.activity/js/activity.js Outdated Show resolved Hide resolved
activities/Clock.activity/js/activity.js Outdated Show resolved Hide resolved
activities/Clock.activity/lib/tutorial.js Show resolved Hide resolved
@llaske llaske merged commit bb50817 into llaske:dev Dec 21, 2019
@llaske llaske mentioned this pull request Dec 21, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants