Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for Calculate activity #537

Merged
merged 5 commits into from
Dec 30, 2019
Merged

Add tutorial for Calculate activity #537

merged 5 commits into from
Dec 30, 2019

Conversation

sdziuda
Copy link
Contributor

@sdziuda sdziuda commented Dec 27, 2019

Added the tutorial for Calculate activity

sdziuda and others added 3 commits December 28, 2019 00:25
Added the tutorial for Calculate activity
Fixed indentation in tutorial.js
@llaske
Copy link
Owner

llaske commented Dec 28, 2019

That's nice.

Could use media queries to hide the help button on small screens? Currently the button override the body part. See below:

Capture du 2019-12-28 18-45-44

Made the button hidden when window is reduced to exact point
@prakashujjwal1010
Copy link
Contributor

@sdziuda , I think you should add translated strings in fr, es, pt sections in locale.ini. you can use google translate for it :)

Added translations for tutorial in es, fr and pt
@sdziuda
Copy link
Contributor Author

sdziuda commented Dec 29, 2019

Thanks for an advice @prakashujjwal1010 :)
As you had suggeted, I added the translations in es, fr and pt from google translate.

@AndreaGon
Copy link
Contributor

I don't think it's necessary to add the translations. I've tried it before, but @llaske reverted it back to English. See his comment on my PR #512.

Although I still do translate it to fr, for testing purposes.

@sdziuda
Copy link
Contributor Author

sdziuda commented Dec 29, 2019

Yeah, after I thought about it for a while, probably google translate is not the best translator (for sure it is not as good as human). But in the end it is @llaske choice about which language will be merged into dev branch.

@llaske llaske merged commit 10aad21 into llaske:dev Dec 30, 2019
@llaske
Copy link
Owner

llaske commented Dec 30, 2019

@AndreaGon is right, you don't need to translate because I think it's better to let a native user localize its part. BTW it's nice to test with another language from the one in the browser to ensure tutorial localization work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants