workflows/release-binaries: Always pull composite actions from main branch #100805
Conversation
…ranch If we pull from the release tag, then if there is a bug in one of the actions on the release tag, then we can never do a build for that tag. Pulling from main will allows us to fix bugs in the actions we use to build the releases.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesIf we pull from the release tag, then if there is a bug in one of the actions on the release tag, then we can never do a build for that tag. Pulling from main will allows us to fix bugs in the actions we use to build the releases. Full diff: https://github.com/llvm/llvm-project/pull/100805.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 0a800fd006e9d..5250a9fd4cae1 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -148,6 +148,20 @@ jobs:
if: github.repository == 'llvm/llvm-project'
runs-on: ${{ inputs.runs-on }}
steps:
+
+ - name: Checkout Actions
+ uses: actions/checkout@v4
+ with:
+ ref: ${{ (github.event_name == 'pull_request' && github.sha) || 'main' }}
+ sparse-checkout: |
+ .github/workflows/
+ sparse-checkout-cone-mode: false
+ path: workflows
+
+ - name: Setup Stage
+ id: setup-stage
+ uses: ./workflows/.github/workflows/release-binaries-setup-stage
+
- name: Checkout LLVM
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
@@ -161,10 +175,6 @@ jobs:
key: sccache-${{ runner.os }}-${{ runner.arch }}-release
variant: sccache
- - name: Setup Stage
- id: setup-stage
- uses: ./.github/workflows/release-binaries-setup-stage
-
- name: Build Stage 1 Clang
id: build
shell: bash
@@ -184,7 +194,7 @@ jobs:
ls -ltr ${{ steps.setup-stage.outputs.build-prefix }}/build
- name: Save Stage
- uses: ./.github/workflows/release-binaries-save-stage
+ uses: ./workflows/.github/workflows/release-binaries-save-stage
with:
build-prefix: ${{ steps.setup-stage.outputs.build-prefix }}
|
| sparse-checkout-cone-mode: false | ||
| path: workflows | ||
|
|
||
| - name: Setup Stage |
There was a problem hiding this comment.
I'm assuming this moved up here so it can use the just pulled in action definition?
The subsequent LLVM checkout ends up overriding this?
There was a problem hiding this comment.
The next checkout won't override this, so I didn't have to move this. The reason I did was to match the other stages which have these two steps next to each other.
There was a problem hiding this comment.
Makes sense.
For some reason I missed the path argument in my initial readover. This makes more sense now.
There was a problem hiding this comment.
I was wrong, the checkout does overwrite this. See #100845.
| @@ -148,6 +148,20 @@ jobs: | |||
| if: github.repository == 'llvm/llvm-project' | |||
| runs-on: ${{ inputs.runs-on }} | |||
| steps: | |||
|
|
|||
| - name: Checkout Actions | |||
| uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
Probably should be hash pinned to the same version as below.
|
Should have looked closer, the test failure didn't show up in the checks list, I think because there was a bug in the yml. I'll push a fix-up commit. |
…ranch (llvm#100805) If we pull from the release tag, then if there is a bug in one of the actions on the release tag, then we can never do a build for that tag. Pulling from main will allows us to fix bugs in the actions we use to build the releases. (cherry picked from commit b0860b2)
…ranch (llvm#100805) If we pull from the release tag, then if there is a bug in one of the actions on the release tag, then we can never do a build for that tag. Pulling from main will allows us to fix bugs in the actions we use to build the releases. (cherry picked from commit b0860b2)
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
If we pull from the release tag, then if there is a bug in one of the actions on the release tag, then we can never do a build for that tag. Pulling from main will allows us to fix bugs in the actions we use to build the releases.