workflows/release-binaries: Always pull composite actions from main branch #100805
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,6 +148,20 @@ jobs: | |
| if: github.repository == 'llvm/llvm-project' | ||
| runs-on: ${{ inputs.runs-on }} | ||
| steps: | ||
|
|
||
| - name: Checkout Actions | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ (github.event_name == 'pull_request' && github.sha) || 'main' }} | ||
| sparse-checkout: | | ||
| .github/workflows/ | ||
| sparse-checkout-cone-mode: false | ||
| path: workflows | ||
|
|
||
| - name: Setup Stage | ||
|
There was a problem hiding this comment. I'm assuming this moved up here so it can use the just pulled in action definition? The subsequent LLVM checkout ends up overriding this? There was a problem hiding this comment. The next checkout won't override this, so I didn't have to move this. The reason I did was to match the other stages which have these two steps next to each other. There was a problem hiding this comment. Makes sense. For some reason I missed the There was a problem hiding this comment. I was wrong, the checkout does overwrite this. See #100845. |
||
| id: setup-stage | ||
| uses: ./workflows/.github/workflows/release-binaries-setup-stage | ||
|
|
||
| - name: Checkout LLVM | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | ||
| with: | ||
|
|
@@ -161,10 +175,6 @@ jobs: | |
| key: sccache-${{ runner.os }}-${{ runner.arch }}-release | ||
| variant: sccache | ||
|
|
||
| - name: Build Stage 1 Clang | ||
| id: build | ||
| shell: bash | ||
|
|
@@ -184,7 +194,7 @@ jobs: | |
| ls -ltr ${{ steps.setup-stage.outputs.build-prefix }}/build | ||
|
|
||
| - name: Save Stage | ||
| uses: ./workflows/.github/workflows/release-binaries-save-stage | ||
| with: | ||
| build-prefix: ${{ steps.setup-stage.outputs.build-prefix }} | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be hash pinned to the same version as below.