Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT] Enhance LowerAnnotations pass. NFCI. #71847

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

maksfb
Copy link
Contributor

@maksfb maksfb commented Nov 9, 2023

After #70147, all primary annotation types are stored directly in the instruction and hence there's no need for the temporary storage we've used previously for repopulating preserved annotations.

After llvm#70147, all primary annotation types are stored directly in the
instruction and hence there's no need for the temporary storage we've
used previously for repopulating preserved annotations.
@maksfb maksfb added the BOLT label Nov 9, 2023
@aaupov
Copy link
Contributor

aaupov commented Nov 9, 2023

s/Enchance/Enhance/

@maksfb maksfb changed the title [BOLT] Enchance LowerAnnotations pass. NFCI. [BOLT] Enhance LowerAnnotations pass. NFCI. Nov 9, 2023
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@maksfb maksfb merged commit ec4a03c into llvm:main Nov 13, 2023
4 checks passed
@maksfb maksfb deleted the gh-lower-annotations branch November 15, 2023 20:28
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
After llvm#70147, all primary annotation types are stored directly in the
instruction and hence there's no need for the temporary storage we've
used previously for repopulating preserved annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants