Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't explicitly set MLIR_PDLL_TABLEGEN_EXE #1262

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

marbre
Copy link
Member

@marbre marbre commented Aug 22, 2022

With llvm/llvm-project@91b6f76, the variable MLIR_PDLL_TABLEGEN_EXE is
set as a cache variable in MLIR upstream.

Likely requires an update of externals/mlir-hlo to
tensorflow/mlir-hlo@4f2a00b or later.

With llvm/llvm-project@91b6f76, the variable `MLIR_PDLL_TABLEGEN_EXE` is
set as a cache variable in MLIR upstream.

Likely requires an update of externals/mlir-hlo to
tensorflow/mlir-hlo@4f2a00b or later.
Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, are you going to wait until the bump happens? (I'm assuming no presubmits fail here for related reason as this is only enabled for the MHLO and that's not yet part of presubmit).

Copy link
Collaborator

@powderluv powderluv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@marbre
Copy link
Member Author

marbre commented Aug 22, 2022

Change looks good, are you going to wait until the bump happens? (I'm assuming no presubmits fail here for related reason as this is only enabled for the MHLO and that's not yet part of presubmit).

I know that a similar fix "broke" IREE but I think in that case the underlying LLVM-integrate was missing. That is not the case here (the LLVM version used includes llvm/llvm-project@91b6f76) though we could probably merge without breaking anything. However, the change might only fully functional after MLIR-HLO is up-to-date enough as well.

@marbre marbre merged commit 1f1abda into llvm:main Aug 22, 2022
@marbre marbre deleted the mlir-pdll-tblgen branch August 22, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants