Add shapelib and Torch ODS gen tests #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powderluv
force-pushed
the
warn-shape-lib
branch
from
2bffba6
to
ae01bf2
Compare
ashay
reviewed
Aug 31, 2022
Also update the scripts to return 1 when there are changes. The
tests can check and report if there are any changes.
TEST:
The passing tests look like:
:::: Run shapelib update tests
Shape Lib is up to date
:::: Run torch_ods update tests
Torch ODS is up to date
Failing would like like:
anush@sdp ~/github/torch-mlir % time ./build_tools/update_shape_lib.sh
PYTHONPATH=/home/anush/github/torch-mlir/build/tools/torch-mlir/python_packages/torch_mlir python -m torch_mlir.dialects.torch.importer.jit_ir.build_tools.shape_lib_gen --pytorch_op_extensions= --torch_transforms_cpp_dir=/home/anush/github/torch-mlir/lib/Dialect/Torch
/Transforms
Generated files are not up to date (see diff below)
>>> Please run ./build_tools/update_torch_ods.sh and ./build_tools/update_shape_lib.sh <<<
diff --git a/lib/Dialect/Torch/Transforms/ShapeLibrary.cpp b/lib/Dialect/Torch/Transforms/ShapeLibrary.cpp
index f7a8f69c..a780ee33 100644
--- a/lib/Dialect/Torch/Transforms/ShapeLibrary.cpp
+++ b/lib/Dialect/Torch/Transforms/ShapeLibrary.cpp
@@ -14,6 +14,8 @
#include "torch-mlir/Dialect/Torch/Transforms/Passes.h"
+foo
+
using namespace mlir;
StringRef mlir::torch::Torch::getShapeLibrary() {
./build_tools/update_shape_lib.sh 0.02s user 0.01s system 104% cpu 0.035 total
I updated the CI to not hard fail when there is diff. If we pin Pytorch
we can hard fail in the future
powderluv
force-pushed
the
warn-shape-lib
branch
from
ae01bf2
to
ad2b115
Compare
silvasean
approved these changes
Aug 31, 2022
silvasean
approved these changes
Aug 31, 2022
AmosLewis
pushed a commit
to AmosLewis/torch-mlir
that referenced
this pull request
Sep 1, 2022
AmosLewis
pushed a commit
to AmosLewis/torch-mlir
that referenced
this pull request
Sep 2, 2022
AmosLewis
pushed a commit
to AmosLewis/torch-mlir
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the scripts to return 1 when there are changes. The tests can check and report if there are any changes. But you get a warning even when you run it outside of the CI.
TEST:
The passing tests look like:
:::: Run shapelib update tests
Shape Lib is up to date
:::: Run torch_ods update tests
Torch ODS is up to date
Failing would like like:
Fixes Issue #1317