Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper config location #2115

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

rohantmp
Copy link
Contributor

@rohantmp rohantmp commented Sep 5, 2024

respect the --config flag and it's defaults

part of ENG-4398

Signed-off-by: Rohan CJ <rohantmp@gmail.com>
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for vcluster-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 16f6ebd
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66d9696e665dab0008892987
😎 Deploy Preview https://deploy-preview-2115--vcluster-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohantmp rohantmp marked this pull request as draft September 5, 2024 08:21
@rohantmp rohantmp marked this pull request as ready for review September 6, 2024 07:44
@FabianKramm FabianKramm merged commit fe1fbd0 into loft-sh:main Sep 9, 2024
61 checks passed
@FabianKramm FabianKramm added the backport-to-v0.20 backport this PR to v0.20 branch label Sep 9, 2024
@loft-bot
Copy link
Collaborator

loft-bot commented Sep 9, 2024

💔 All backports failed

Status Branch Result
v0.20 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 2115

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@loft-bot
Copy link
Collaborator

loft-bot commented Sep 9, 2024

💔 All backports failed

Status Branch Result
v0.20 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 2115

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@rohantmp
Copy link
Contributor Author

rohantmp commented Sep 9, 2024

Will manually backport to v0.20 with the changes at #2112 once that is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.20 backport this PR to v0.20 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants