[0.20] fix: create --connect fails because of improper config location, remove duplicate flags, drop duplicate functionality #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
changed the title
rohantmp
changed the title
|
Hold off on merging without considering the changes in flags. I do think they should be backported as the combination doesn't make sense and both flags have to be disabled to set to false to not connect when creating. |
FabianKramm
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves ENG-4557
manual backport of #2115 and #2112
Hold off on merging without considering the changes in flags. I do think they should be backported as the combination doesn't make sense and both flags have to be disabled to set to false to not connect when creating.