build: install latest grpc_health_probe #1269
Conversation
WalkthroughThe pull request modifies the Dockerfile to improve the build process by integrating the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
longhorn/longhorn-9714 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
9714-build-grpc-health-probe
branch
from
e0fa16b to
3566824
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
package/Dockerfile (1)
Line range hint
49-50: Remove unnecessary jq package from release stage.The
jqpackage is only needed during build time for parsing the GitHub API response. It's not required in the final image and should be removed to reduce image size.RUN zypper -n install nfs-client nfs4-acl-tools cifs-utils libaio1 sg3_utils \ - iputils iproute2 qemu-tools e2fsprogs jq && \ + iputils iproute2 qemu-tools e2fsprogs && \ rm -rf /var/cache/zypp/*🧰 Tools
🪛 GitHub Check: CodeFactor
[warning] 12-12: package/Dockerfile#L12
Specify version withzypper install -y <package>=<version>. (DL3037)
[warning] 12-12: package/Dockerfile#L12
zypper cleanmissing after zypper use. (DL3036)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- package/Dockerfile (2 hunks)
🧰 Additional context used
🪛 GitHub Check: CodeFactor
package/Dockerfile
[warning] 12-12: package/Dockerfile#L12
Specify version withzypper install -y <package>=<version>. (DL3037)
[warning] 12-12: package/Dockerfile#L12
zypper cleanmissing after zypper use. (DL3036)
[notice] 34-34: package/Dockerfile#L34
Avoid use of wget without progress bar. Usewget --progress=dot:giga <url>. Or consider using-qor-nv(shorthands for--quietor--no-verbose). (DL3047)
🔇 Additional comments (1)
package/Dockerfile (1)
34-36: Verify architecture support.Please ensure that the dynamic URL fetching works for all supported architectures.
✅ Verification successful
Let me try a different approach using
curlinstead ofwgetsince it seemswgetis not available in the sandbox environment.
Dynamic URL fetching works correctly for all architectures
The verification confirms that the latest grpc_health_probe release (v0.4.34) provides binaries for all common architectures:
- linux-amd64
- linux-arm64
- linux-arm
The dynamic URL fetching approach in the Dockerfile will work reliably across different architectures as intended.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify grpc_health_probe availability for common architectures ARCHS=("amd64" "arm64" "arm") for arch in "${ARCHS[@]}"; do echo "Checking availability for arch: $arch" wget -qO- https://api.github.com/repos/grpc-ecosystem/grpc-health-probe/releases/latest | \ jq -r --arg ARCH "$arch" '.assets[] | select(.name | test("linux.*" + $ARCH; "i")) | .browser_download_url' doneLength of output: 1174
Script:
#!/bin/bash # Description: Verify grpc_health_probe availability for common architectures using curl ARCHS=("amd64" "arm64" "arm") for arch in "${ARCHS[@]}"; do echo "Checking availability for arch: $arch" curl -s https://api.github.com/repos/grpc-ecosystem/grpc-health-probe/releases/latest | \ jq -r --arg ARCH "$arch" '.assets[] | select(.name | test("linux.*" + $ARCH; "i")) | .browser_download_url' doneLength of output: 1382
🧰 Tools
🪛 GitHub Check: CodeFactor
[notice] 34-34: package/Dockerfile#L34
Avoid use of wget without progress bar. Usewget --progress=dot:giga <url>. Or consider using-qor-nv(shorthands for--quietor--no-verbose). (DL3047)
|
@mergify backport v1.7.x v1.6.x |
✅ Backports have been created
|
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9714
What this PR does / why we need it:
Install the latest grpc_health_probe at build time.
Special notes for your reviewer:
NoneAdditional documentation or context
None