Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install latest grpc_health_probe #1269

Merged
merged 1 commit into from
Oct 28, 2024
+3 −2
Merged

build: install latest grpc_health_probe #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
zypper -n addrepo --refresh https://download.opensuse.org/repositories/network:/utilities/SLE_15_SP5/network:utilities.repo && \
zypper --gpg-auto-import-keys ref

RUN zypper -n install cmake curl git gcc wget xsltproc docbook-xsl-stylesheets && \
RUN zypper -n install cmake curl git gcc wget xsltproc docbook-xsl-stylesheets jq && \

Check warning on line 12 in package/Dockerfile

View check run for this annotation

codefactor.io / CodeFactor

package/Dockerfile#L12 

Specify version with `zypper install -y <package>=<version>`. (DL3037)

Check warning on line 12 in package/Dockerfile

View check run for this annotation

codefactor.io / CodeFactor

package/Dockerfile#L12 

`zypper clean` missing after zypper use. (DL3036)
rm -rf /var/cache/zypp/*
c3y1huang marked this conversation as resolved.
Show resolved Hide resolved

# Build liblonghorn
Expand All @@ -31,7 +31,8 @@
make install

# Install grpc_health_probe
RUN wget https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/v0.4.28/grpc_health_probe-linux-${ARCH} -O /usr/local/bin/grpc_health_probe && \
RUN GRPC_HEALTH_PROBE_DOWNLOAD_URL=$(wget -qO- https://api.github.com/repos/grpc-ecosystem/grpc-health-probe/releases/latest | jq -r '.assets[] | select(.name | test("linux.*'"${ARCH}"'"; "i")) | .browser_download_url') && \

Check notice on line 34 in package/Dockerfile

View check run for this annotation

codefactor.io / CodeFactor

package/Dockerfile#L34 

Avoid use of wget without progress bar. Use `wget --progress=dot:giga <url>`. Or consider using `-q` or `-nv` (shorthands for `--quiet` or `--no-verbose`). (DL3047)
wget ${GRPC_HEALTH_PROBE_DOWNLOAD_URL} -O /usr/local/bin/grpc_health_probe && \
chmod +x /usr/local/bin/grpc_health_probe
c3y1huang marked this conversation as resolved.
Show resolved Hide resolved

FROM registry.suse.com/bci/bci-base:15.6 AS release
Expand Down