Reword the message printed by REST LogError action #6556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the message from "unhandled error" to "request failed". The original message was often creating confusion for our users. It seemed like the error was not handled at all, when in fact it was caught by the configured error handler and converted into a proper HTTP error response. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
added
developer-experience
bajtos
changed the title
bajtos
force-pushed
the
feat/reword-rest-error-log
branch
from
2ce9da2
to
959e507
Compare
hacksparrow
approved these changes
Oct 13, 2020
emonddr
approved these changes
Oct 13, 2020
raymondfeng
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the message from "unhandled error" to "request failed".
The original message was often creating confusion for our users. It seemed like the error was not handled at all, when in fact it was caught by the configured error handler and converted into a proper HTTP error response.
See the discussion in loopbackio/strong-error-handler#54 and also loopbackio/strong-error-handler#91.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈