Reword log messages for better clarity #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we logged messages saying "unhandled error". This was often creating confusion for our users, it seems like the error was not handled at all, when in fact it was caught by the configured error handler and converted into a proper HTTP error response. In this commit, I am changing the messaging to use "request failed" instead. While this change is not affecting application developers, it may break tooling processing logs if the tool relies on a specific format of error messages. To be safe, I am labelling this change as breaking. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
raymondfeng
approved these changes
Oct 12, 2020
This was referenced Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we logged messages saying "unhandled error". This was often creating confusion for our users, it seems like the error was not handled at all, when in fact it was caught by the configured error handler and converted into a proper HTTP error response.
In this commit, I am changing the messaging to use "request failed" instead.
While this change is not affecting application developers, it may break tooling processing logs if the tool relies on a specific format of error messages. To be safe, I am labelling this change as breaking.
Close #54