Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword log messages for better clarity #91

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Reword log messages for better clarity #91

merged 2 commits into from
Oct 13, 2020

Commits on Oct 12, 2020

  1. [SEMVER-MAJOR] Reword log messages for clarity 

    Before this commit, we logged messages saying "unhandled error". This
was often creating confusion for our users, it seems like the error
was not handled at all, when in fact it was caught by the configured
error handler and converted into a proper HTTP error response.

In this commit, I am changing the messaging to use "request failed"
instead.

While this change is not affecting application developers, it may
break tooling processing logs if the tool relies on a specific format
of error messages. To be safe, I am labelling this change as breaking.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
    @bajtos
    bajtos committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    7b61bcd View commit details
    Browse the repository at this point in the history

  2. docs: update LTS versions in README 

    Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
    @bajtos
    bajtos committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    b8cb893 View commit details
    Browse the repository at this point in the history