refactor: Update Has operation.

BREAKING CHANGE: yes
loophp · Oct 7, 2020 · 082384b · 082384b
1 parent b761ce7
commit 082384b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/spec/loophp/collection/CollectionSpec.php b/spec/loophp/collection/CollectionSpec.php
@@ -1075,13 +1075,13 @@ public function it_can_has(): void
             ->has(static function ($key, $value) {
                 return 'A';
             })
-            ->shouldReturn(true);
+            ->shouldIterateAs([true]);
 
         $this::fromIterable(range('A', 'C'))
             ->has(static function ($key, $value) {
                 return 'Z';
             })
-            ->shouldReturn(false);
+            ->shouldIterateAs([false]);
     }
 
     public function it_can_head(): void

diff --git a/src/Collection.php b/src/Collection.php
@@ -517,9 +517,9 @@ public function groupBy(?callable $callable = null): CollectionInterface
         return $this->pipe(GroupBy::of()($callable));
     }
 
-    public function has(callable $callback): bool
+    public function has(callable $callback): CollectionInterface
     {
-        return $this->pipe(Has::of()($callback))->getIterator()->current();
+        return $this->pipe(Has::of()($callback));
     }
 
     public function head(): CollectionInterface

diff --git a/src/Contract/Operation/Hasable.php b/src/Contract/Operation/Hasable.php
@@ -4,6 +4,8 @@
 
 namespace loophp\collection\Contract\Operation;
 
+use loophp\collection\Contract\Collection;
+
 /**
  * @psalm-template TKey
  * @psalm-template TKey of array-key
@@ -12,7 +14,9 @@
 interface Hasable
 {
     /**
-     * @psalm-param callable(TKey, T):(bool) $callback
+     * @psalm-param callable(TKey, T): bool $callback
+     *
+     * @psalm-return \loophp\collection\Contract\Collection<int, bool>
      */
-    public function has(callable $callback): bool;
+    public function has(callable $callback): Collection;
 }