Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop issues from #861 #870

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Fix rubocop issues from #861 #870

merged 1 commit into from
Feb 25, 2019

Conversation

technoweenie
Copy link
Member

Goal is to fix the rubocop failures in master that came from #861:

spec/support/shared_examples/request_method.rb:53:9: C: Layout/IndentationWidth: Use 2 (not -4) spaces for indentation. (https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation)
        conn.public_send(http_method, '/', 'test')
        ^^^^
spec/support/shared_examples/request_method.rb:54:7: C: Layout/ElseAlignment: Align else with if.
      else
      ^^^^
spec/support/shared_examples/request_method.rb:58:7: W: Layout/EndAlignment: end at 58, 6 is not aligned with if at 52, 12.
      end
      ^^^
spec/support/shared_examples/adapter.rb:82:3: C: Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. (https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation)
   let(:http_method) { :options }
  ^
spec/support/shared_examples/adapter.rb:84:5: C: Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation)
    it_behaves_like 'a request method', :options
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/shared_examples/adapter.rb:107:5: C: Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. (https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation)
     let(:http_method) { :trace }
    ^
spec/support/shared_examples/adapter.rb:109:7: C: Layout/IndentationConsistency: Inconsistent indentation detected. (https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation)
      it_behaves_like 'a request method', :trace
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@technoweenie
Copy link
Member Author

@iMacTia Code Climate did not catch the rubocop failure. I still get the first 3 offenses.

@technoweenie technoweenie merged commit 627ed87 into master Feb 25, 2019
@technoweenie technoweenie deleted the rubocop-failures-861 branch February 25, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant